mirror of
https://github.com/ElementsProject/lightning.git
synced 2025-02-22 06:41:44 +01:00
2ac775f9f4
It's foolish to ban passing NULL, 0 to memcpy, memset et al, but it's been done. At high level of optimization, GCC assumes this doesn't happen, and yep, assumes "if (ctx)" inside tal_free() must be true. So when a psbt is NULL, and psbt_get_bytes returns NULL, a crash ensues: ``` lightningd: FATAL SIGNAL 6 (version v0.12.0rc2-6-g47efa5d-modded) 0x5557dfc42fef send_backtrace common/daemon.c:33 0x5557dfc42fef crashdump common/daemon.c:46 0x7fe93ef5851f ??? ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0 0x7fe93efaca7c __pthread_kill_implementation ./nptl/pthread_kill.c:44 0x7fe93efaca7c __pthread_kill_internal ./nptl/pthread_kill.c:78 0x7fe93efaca7c __GI___pthread_kill ./nptl/pthread_kill.c:89 0x7fe93ef58475 __GI_raise ../sysdeps/posix/raise.c:26 0x7fe93ef3e7f2 __GI_abort ./stdlib/abort.c:79 0x5557dfbb0c28 call_error ccan/ccan/tal/tal.c:93 0x5557dfbb0c34 check_bounds ccan/ccan/tal/tal.c:165 0x5557dfbb0c34 to_tal_hdr ccan/ccan/tal/tal.c:178 0x5557dfc7a1d3 tal_free ccan/ccan/tal/tal.c:482 0x5557dfc609d3 tal_free ccan/ccan/tal/tal.c:477 0x5557dfc609d3 towire_wally_psbt bitcoin/psbt.c:743 0x5557dfbc5dfc towire_dualopend_got_offer_reply openingd/dualopend_wiregen.c:358 0x5557dfbc5dfc openchannel2_hook_cb lightningd/dual_open_control.c:671 0x5557dfc22f4f plugin_hook_callback lightningd/plugin_hook.c:210 0x5557dfc1dfbe plugin_response_handle lightningd/plugin.c:591 0x5557dfc1dfbe plugin_read_json_one lightningd/plugin.c:702 0x5557dfc1dfbe plugin_read_json lightningd/plugin.c:747 0x5557dfc71756 next_plan ccan/ccan/io/io.c:59 0x5557dfc775d5 io_ready ccan/ccan/io/io.c:417 0x5557dfc775d5 io_loop ccan/ccan/io/poll.c:453 0x5557dfbdb1ce io_loop ccan/ccan/io/poll.c:380 0x5557dfbdb1ce io_loop_with_timers lightningd/io_loop_with_timers.c:22 0x5557dfbb37d1 main lightningd/lightningd.c:1195 0x7fe93ef3fd8f __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 0x7fe93ef3fe3f __libc_start_main_impl ../csu/libc-start.c:392 0x5557dfbb6e84 ??? ???:0 0xffffffffffffffff ??? ???:0 ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
147 lines
2.9 KiB
C
147 lines
2.9 KiB
C
#include "config.h"
|
|
#include "wire.h"
|
|
#include <assert.h>
|
|
#include <ccan/crypto/siphash24/siphash24.h>
|
|
#include <ccan/endian/endian.h>
|
|
#include <ccan/mem/mem.h>
|
|
#include <common/utils.h>
|
|
|
|
void towire(u8 **pptr, const void *data, size_t len)
|
|
{
|
|
size_t oldsize = tal_count(*pptr);
|
|
|
|
tal_resize(pptr, oldsize + len);
|
|
/* The C standards committee has a lot to answer for :( */
|
|
if (len)
|
|
memcpy(*pptr + oldsize, memcheck(data, len), len);
|
|
}
|
|
|
|
void towire_u8(u8 **pptr, u8 v)
|
|
{
|
|
towire(pptr, &v, sizeof(v));
|
|
}
|
|
|
|
void towire_u16(u8 **pptr, u16 v)
|
|
{
|
|
be16 l = cpu_to_be16(v);
|
|
towire(pptr, &l, sizeof(l));
|
|
}
|
|
|
|
void towire_u32(u8 **pptr, u32 v)
|
|
{
|
|
be32 l = cpu_to_be32(v);
|
|
towire(pptr, &l, sizeof(l));
|
|
}
|
|
|
|
void towire_u64(u8 **pptr, u64 v)
|
|
{
|
|
be64 l = cpu_to_be64(v);
|
|
towire(pptr, &l, sizeof(l));
|
|
}
|
|
|
|
static void towire_tlv_uint(u8 **pptr, u64 v)
|
|
{
|
|
u8 bytes[8];
|
|
size_t num_zeroes;
|
|
be64 val;
|
|
|
|
val = cpu_to_be64(v);
|
|
BUILD_ASSERT(sizeof(val) == sizeof(bytes));
|
|
memcpy(bytes, &val, sizeof(bytes));
|
|
|
|
for (num_zeroes = 0; num_zeroes < sizeof(bytes); num_zeroes++)
|
|
if (bytes[num_zeroes] != 0)
|
|
break;
|
|
|
|
towire(pptr, bytes + num_zeroes, sizeof(bytes) - num_zeroes);
|
|
}
|
|
|
|
void towire_tu16(u8 **pptr, u16 v)
|
|
{
|
|
return towire_tlv_uint(pptr, v);
|
|
}
|
|
|
|
void towire_tu32(u8 **pptr, u32 v)
|
|
{
|
|
return towire_tlv_uint(pptr, v);
|
|
}
|
|
|
|
void towire_tu64(u8 **pptr, u64 v)
|
|
{
|
|
return towire_tlv_uint(pptr, v);
|
|
}
|
|
|
|
void towire_bool(u8 **pptr, bool v)
|
|
{
|
|
u8 val = v;
|
|
towire(pptr, &val, sizeof(val));
|
|
}
|
|
|
|
void towire_errcode_t(u8 **pptr, errcode_t v)
|
|
{
|
|
towire_u32(pptr, (u32)v);
|
|
}
|
|
|
|
void towire_secp256k1_ecdsa_signature(u8 **pptr,
|
|
const secp256k1_ecdsa_signature *sig)
|
|
{
|
|
u8 compact[64];
|
|
|
|
secp256k1_ecdsa_signature_serialize_compact(secp256k1_ctx,
|
|
compact, sig);
|
|
towire(pptr, compact, sizeof(compact));
|
|
}
|
|
|
|
void towire_secp256k1_ecdsa_recoverable_signature(u8 **pptr,
|
|
const secp256k1_ecdsa_recoverable_signature *rsig)
|
|
{
|
|
u8 compact[64];
|
|
int recid;
|
|
|
|
secp256k1_ecdsa_recoverable_signature_serialize_compact(secp256k1_ctx,
|
|
compact,
|
|
&recid,
|
|
rsig);
|
|
towire(pptr, compact, sizeof(compact));
|
|
towire_u8(pptr, recid);
|
|
}
|
|
|
|
void towire_sha256(u8 **pptr, const struct sha256 *sha256)
|
|
{
|
|
towire(pptr, sha256, sizeof(*sha256));
|
|
}
|
|
|
|
void towire_ripemd160(u8 **pptr, const struct ripemd160 *ripemd)
|
|
{
|
|
towire(pptr, ripemd, sizeof(*ripemd));
|
|
}
|
|
|
|
void towire_u8_array(u8 **pptr, const u8 *arr, size_t num)
|
|
{
|
|
towire(pptr, arr, num);
|
|
}
|
|
|
|
void towire_utf8_array(u8 **pptr, const char *arr, size_t num)
|
|
{
|
|
assert(utf8_check(arr, num));
|
|
towire(pptr, arr, num);
|
|
}
|
|
|
|
void towire_pad(u8 **pptr, size_t num)
|
|
{
|
|
/* Simply insert zeros. */
|
|
size_t oldsize = tal_count(*pptr);
|
|
|
|
tal_resize(pptr, oldsize + num);
|
|
memset(*pptr + oldsize, 0, num);
|
|
}
|
|
|
|
void towire_wirestring(u8 **pptr, const char *str)
|
|
{
|
|
towire(pptr, str, strlen(str) + 1);
|
|
}
|
|
|
|
void towire_siphash_seed(u8 **pptr, const struct siphash_seed *seed)
|
|
{
|
|
towire(pptr, seed, sizeof(*seed));
|
|
}
|