mirror of
https://github.com/ElementsProject/lightning.git
synced 2024-11-19 18:11:28 +01:00
d27a5d3212
Especially under valgrind, we should give them some time to exit. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
465 lines
11 KiB
C
465 lines
11 KiB
C
#include <ccan/io/fdpass/fdpass.h>
|
|
#include <ccan/io/io.h>
|
|
#include <ccan/noerr/noerr.h>
|
|
#include <ccan/take/take.h>
|
|
#include <ccan/tal/path/path.h>
|
|
#include <daemon/log.h>
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <lightningd/lightningd.h>
|
|
#include <lightningd/status.h>
|
|
#include <lightningd/subd.h>
|
|
#include <stdarg.h>
|
|
#include <sys/socket.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <sys/wait.h>
|
|
#include <unistd.h>
|
|
#include <wire/wire.h>
|
|
#include <wire/wire_io.h>
|
|
|
|
static bool move_fd(int from, int to)
|
|
{
|
|
if (dup2(from, to) == -1)
|
|
return false;
|
|
close(from);
|
|
return true;
|
|
}
|
|
|
|
/* FIXME: Expose the ccan/io version? */
|
|
static void set_blocking(int fd, bool block)
|
|
{
|
|
int flags = fcntl(fd, F_GETFL);
|
|
|
|
if (block)
|
|
flags &= ~O_NONBLOCK;
|
|
else
|
|
flags |= O_NONBLOCK;
|
|
|
|
fcntl(fd, F_SETFL, flags);
|
|
}
|
|
|
|
struct subd_req {
|
|
struct list_node list;
|
|
|
|
/* Callback for a reply. */
|
|
int reply_type;
|
|
bool (*replycb)(struct subd *, const u8 *, const int *, void *);
|
|
void *replycb_data;
|
|
|
|
size_t num_reply_fds;
|
|
/* If non-NULL, this is here to disable replycb */
|
|
void *disabler;
|
|
};
|
|
|
|
static void free_subd_req(struct subd_req *sr)
|
|
{
|
|
list_del(&sr->list);
|
|
/* Don't disable once we're freed! */
|
|
if (sr->disabler)
|
|
tal_free(sr->disabler);
|
|
}
|
|
|
|
/* Called when the callback is disabled because caller was freed. */
|
|
static bool ignore_reply(struct subd *sd, const u8 *msg, const int *fds,
|
|
void *arg)
|
|
{
|
|
size_t i;
|
|
|
|
log_debug(sd->log, "IGNORING REPLY");
|
|
for (i = 0; i < tal_count(fds); i++)
|
|
close(fds[i]);
|
|
return true;
|
|
}
|
|
|
|
static void disable_cb(void *disabler, struct subd_req *sr)
|
|
{
|
|
sr->replycb = ignore_reply;
|
|
sr->disabler = NULL;
|
|
}
|
|
|
|
static void add_req(const tal_t *ctx,
|
|
struct subd *sd, int type, size_t num_fds_in,
|
|
bool (*replycb)(struct subd *, const u8 *, const int *,
|
|
void *),
|
|
void *replycb_data)
|
|
{
|
|
struct subd_req *sr = tal(sd, struct subd_req);
|
|
|
|
sr->reply_type = type + SUBD_REPLY_OFFSET;
|
|
sr->replycb = replycb;
|
|
sr->replycb_data = replycb_data;
|
|
sr->num_reply_fds = num_fds_in;
|
|
|
|
/* We don't allocate sr off ctx, because we still have to handle the
|
|
* case where ctx is freed between request and reply. Hence this
|
|
* trick. */
|
|
if (ctx) {
|
|
sr->disabler = tal(ctx, char);
|
|
tal_add_destructor2(sr->disabler, disable_cb, sr);
|
|
} else
|
|
sr->disabler = NULL;
|
|
assert(strends(sd->msgname(sr->reply_type), "_REPLY"));
|
|
|
|
/* Keep in FIFO order: we sent in order, so replies will be too. */
|
|
list_add_tail(&sd->reqs, &sr->list);
|
|
tal_add_destructor(sr, free_subd_req);
|
|
}
|
|
|
|
/* Caller must free. */
|
|
static struct subd_req *get_req(struct subd *sd, int reply_type)
|
|
{
|
|
struct subd_req *sr;
|
|
|
|
list_for_each(&sd->reqs, sr, list) {
|
|
if (sr->reply_type == reply_type)
|
|
return sr;
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
/* We use sockets, not pipes, because fds are bidir. */
|
|
static int subd(const char *dir, const char *name, bool debug,
|
|
int *msgfd, va_list ap)
|
|
{
|
|
int childmsg[2], execfail[2];
|
|
pid_t childpid;
|
|
int err, fd;
|
|
|
|
if (socketpair(AF_LOCAL, SOCK_STREAM, 0, childmsg) != 0)
|
|
goto fail;
|
|
|
|
if (pipe(execfail) != 0)
|
|
goto close_msgfd_fail;
|
|
|
|
if (fcntl(execfail[1], F_SETFD, fcntl(execfail[1], F_GETFD)
|
|
| FD_CLOEXEC) < 0)
|
|
goto close_execfail_fail;
|
|
|
|
childpid = fork();
|
|
if (childpid < 0)
|
|
goto close_execfail_fail;
|
|
|
|
if (childpid == 0) {
|
|
int fdnum = 3;
|
|
long max;
|
|
const char *debug_arg = NULL;
|
|
|
|
close(childmsg[0]);
|
|
close(execfail[0]);
|
|
|
|
// msg = STDIN
|
|
if (childmsg[1] != STDIN_FILENO) {
|
|
if (!move_fd(childmsg[1], STDIN_FILENO))
|
|
goto child_errno_fail;
|
|
}
|
|
|
|
/* Dup any extra fds up first. */
|
|
while ((fd = va_arg(ap, int)) != -1) {
|
|
/* If this were stdin, dup2 closed! */
|
|
assert(fd != STDIN_FILENO);
|
|
if (!move_fd(fd, fdnum))
|
|
goto child_errno_fail;
|
|
fdnum++;
|
|
}
|
|
|
|
/* Make (fairly!) sure all other fds are closed. */
|
|
max = sysconf(_SC_OPEN_MAX);
|
|
for (fd = fdnum; fd < max; fd++)
|
|
close(fd);
|
|
|
|
if (debug)
|
|
debug_arg = "--debugger";
|
|
execl(path_join(NULL, dir, name), name, debug_arg, NULL);
|
|
|
|
child_errno_fail:
|
|
err = errno;
|
|
/* Gcc's warn-unused-result fail. */
|
|
if (write(execfail[1], &err, sizeof(err))) {
|
|
;
|
|
}
|
|
exit(127);
|
|
}
|
|
|
|
close(childmsg[1]);
|
|
close(execfail[1]);
|
|
|
|
while ((fd = va_arg(ap, int)) != -1)
|
|
close(fd);
|
|
|
|
/* Child will close this without writing on successful exec. */
|
|
if (read(execfail[0], &err, sizeof(err)) == sizeof(err)) {
|
|
close(execfail[0]);
|
|
waitpid(childpid, NULL, 0);
|
|
errno = err;
|
|
return -1;
|
|
}
|
|
close(execfail[0]);
|
|
*msgfd = childmsg[0];
|
|
return childpid;
|
|
|
|
close_execfail_fail:
|
|
close_noerr(execfail[0]);
|
|
close_noerr(execfail[1]);
|
|
close_msgfd_fail:
|
|
close_noerr(childmsg[0]);
|
|
close_noerr(childmsg[1]);
|
|
fail:
|
|
return -1;
|
|
}
|
|
|
|
static struct io_plan *sd_msg_read(struct io_conn *conn, struct subd *sd);
|
|
|
|
static struct io_plan *sd_msg_reply(struct io_conn *conn, struct subd *sd,
|
|
struct subd_req *sr)
|
|
{
|
|
int type = fromwire_peektype(sd->msg_in);
|
|
bool keep_open;
|
|
|
|
log_info(sd->log, "REPLY %s with %zu fds",
|
|
sd->msgname(type), tal_count(sd->fds_in));
|
|
|
|
/* If not stolen, we'll free this below. */
|
|
tal_steal(sr, sd->msg_in);
|
|
keep_open = sr->replycb(sd, sd->msg_in, sd->fds_in, sr->replycb_data);
|
|
tal_free(sr);
|
|
|
|
if (!keep_open)
|
|
return io_close(conn);
|
|
|
|
/* Free any fd array. */
|
|
sd->fds_in = tal_free(sd->fds_in);
|
|
return io_read_wire(conn, sd, &sd->msg_in, sd_msg_read, sd);
|
|
}
|
|
|
|
static struct io_plan *read_fds(struct io_conn *conn, struct subd *sd)
|
|
{
|
|
if (sd->num_fds_in_read == tal_count(sd->fds_in)) {
|
|
size_t i;
|
|
|
|
/* Don't trust subd to set it blocking. */
|
|
for (i = 0; i < tal_count(sd->fds_in); i++)
|
|
set_blocking(sd->fds_in[i], true);
|
|
return sd_msg_read(conn, sd);
|
|
}
|
|
return io_recv_fd(conn, &sd->fds_in[sd->num_fds_in_read++],
|
|
read_fds, sd);
|
|
}
|
|
|
|
static struct io_plan *sd_collect_fds(struct io_conn *conn, struct subd *sd,
|
|
size_t num_fds)
|
|
{
|
|
assert(!sd->fds_in);
|
|
sd->fds_in = tal_arr(sd, int, num_fds);
|
|
sd->num_fds_in_read = 0;
|
|
return read_fds(conn, sd);
|
|
}
|
|
|
|
static struct io_plan *sd_msg_read(struct io_conn *conn, struct subd *sd)
|
|
{
|
|
int type = fromwire_peektype(sd->msg_in);
|
|
const char *str;
|
|
int str_len;
|
|
const tal_t *tmpctx;
|
|
struct subd_req *sr;
|
|
|
|
if (type == -1) {
|
|
log_unusual(sd->log, "ERROR: Invalid msg output");
|
|
return io_close(conn);
|
|
}
|
|
|
|
/* First, check for replies. */
|
|
sr = get_req(sd, type);
|
|
if (sr) {
|
|
if (sr->num_reply_fds && sd->fds_in == NULL)
|
|
return sd_collect_fds(conn, sd, sr->num_reply_fds);
|
|
|
|
assert(sr->num_reply_fds == tal_count(sd->fds_in));
|
|
return sd_msg_reply(conn, sd, sr);
|
|
}
|
|
|
|
/* If not stolen, we'll free this below. */
|
|
tmpctx = tal_tmpctx(sd);
|
|
tal_steal(tmpctx, sd->msg_in);
|
|
|
|
/* If it's a string. */
|
|
str_len = tal_count(sd->msg_in) - sizeof(be16);
|
|
str = (const char *)sd->msg_in + sizeof(be16);
|
|
|
|
if (type == STATUS_TRACE)
|
|
log_debug(sd->log, "TRACE: %.*s", str_len, str);
|
|
else if (type & STATUS_FAIL)
|
|
log_unusual(sd->log, "FAILURE %s: %.*s",
|
|
sd->msgname(type), str_len, str);
|
|
else {
|
|
log_info(sd->log, "UPDATE %s", sd->msgname(type));
|
|
|
|
if (sd->msgcb) {
|
|
int i = sd->msgcb(sd, sd->msg_in, sd->fds_in);
|
|
if (i < 0)
|
|
return io_close(conn);
|
|
if (i != 0) {
|
|
/* Don't ask for fds twice! */
|
|
assert(!sd->fds_in);
|
|
/* Don't free msg_in: we go around again. */
|
|
tal_steal(sd, sd->msg_in);
|
|
tal_free(tmpctx);
|
|
return sd_collect_fds(conn, sd, i);
|
|
}
|
|
}
|
|
}
|
|
sd->msg_in = NULL;
|
|
sd->fds_in = tal_free(sd->fds_in);
|
|
tal_free(tmpctx);
|
|
return io_read_wire(conn, sd, &sd->msg_in, sd_msg_read, sd);
|
|
}
|
|
|
|
static void destroy_subd(struct subd *sd)
|
|
{
|
|
int status;
|
|
|
|
switch (waitpid(sd->pid, &status, WNOHANG)) {
|
|
case 0:
|
|
log_debug(sd->log, "Status closed, but not exited. Killing");
|
|
kill(sd->pid, SIGKILL);
|
|
waitpid(sd->pid, &status, 0);
|
|
break;
|
|
case -1:
|
|
log_unusual(sd->log, "Status closed, but waitpid %i says %s",
|
|
sd->pid, strerror(errno));
|
|
status = -1;
|
|
break;
|
|
}
|
|
if (sd->finished)
|
|
sd->finished(sd, status);
|
|
}
|
|
|
|
static struct io_plan *msg_send_next(struct io_conn *conn, struct subd *sd)
|
|
{
|
|
const u8 *msg = msg_dequeue(&sd->outq);
|
|
int fd;
|
|
|
|
/* Nothing to do? Wait for msg_enqueue. */
|
|
if (!msg)
|
|
return msg_queue_wait(conn, &sd->outq, msg_send_next, sd);
|
|
|
|
fd = msg_extract_fd(msg);
|
|
if (fd >= 0) {
|
|
tal_free(msg);
|
|
return io_send_fd(conn, fd, true, msg_send_next, sd);
|
|
}
|
|
return io_write_wire(conn, take(msg), msg_send_next, sd);
|
|
}
|
|
|
|
static struct io_plan *msg_setup(struct io_conn *conn, struct subd *sd)
|
|
{
|
|
return io_duplex(conn,
|
|
io_read_wire(conn, sd, &sd->msg_in, sd_msg_read, sd),
|
|
msg_send_next(conn, sd));
|
|
}
|
|
|
|
struct subd *new_subd(const tal_t *ctx,
|
|
struct lightningd *ld,
|
|
const char *name,
|
|
struct peer *peer,
|
|
const char *(*msgname)(int msgtype),
|
|
int (*msgcb)(struct subd *, const u8 *,
|
|
const int *fds),
|
|
void (*finished)(struct subd *, int),
|
|
...)
|
|
{
|
|
va_list ap;
|
|
struct subd *sd = tal(ctx, struct subd);
|
|
int msg_fd;
|
|
bool debug;
|
|
|
|
debug = ld->dev_debug_subdaemon
|
|
&& strends(name, ld->dev_debug_subdaemon);
|
|
va_start(ap, finished);
|
|
sd->pid = subd(ld->daemon_dir, name, debug, &msg_fd, ap);
|
|
va_end(ap);
|
|
if (sd->pid == (pid_t)-1) {
|
|
log_unusual(ld->log, "subd %s failed: %s",
|
|
name, strerror(errno));
|
|
return tal_free(sd);
|
|
}
|
|
sd->ld = ld;
|
|
sd->log = new_log(sd, ld->dstate.log_book, "%s(%u):", name, sd->pid);
|
|
sd->name = name;
|
|
sd->finished = finished;
|
|
sd->msgname = msgname;
|
|
sd->msgcb = msgcb;
|
|
sd->fds_in = NULL;
|
|
msg_queue_init(&sd->outq, sd);
|
|
tal_add_destructor(sd, destroy_subd);
|
|
list_head_init(&sd->reqs);
|
|
|
|
/* conn actually owns daemon: we die when it does. */
|
|
sd->conn = io_new_conn(ctx, msg_fd, msg_setup, sd);
|
|
tal_steal(sd->conn, sd);
|
|
|
|
log_info(sd->log, "pid %u, msgfd %i", sd->pid, msg_fd);
|
|
|
|
sd->peer = tal_steal(sd, peer);
|
|
return sd;
|
|
}
|
|
|
|
void subd_send_msg(struct subd *sd, const u8 *msg_out)
|
|
{
|
|
msg_enqueue(&sd->outq, msg_out);
|
|
}
|
|
|
|
void subd_send_fd(struct subd *sd, int fd)
|
|
{
|
|
msg_enqueue_fd(&sd->outq, fd);
|
|
}
|
|
|
|
void subd_req_(const tal_t *ctx,
|
|
struct subd *sd,
|
|
const u8 *msg_out,
|
|
int fd_out, size_t num_fds_in,
|
|
bool (*replycb)(struct subd *, const u8 *, const int *, void *),
|
|
void *replycb_data)
|
|
{
|
|
/* Grab type now in case msg_out is taken() */
|
|
int type = fromwire_peektype(msg_out);
|
|
|
|
subd_send_msg(sd, msg_out);
|
|
if (fd_out >= 0)
|
|
subd_send_fd(sd, fd_out);
|
|
|
|
add_req(ctx, sd, type, num_fds_in, replycb, replycb_data);
|
|
}
|
|
|
|
void subd_shutdown(struct subd *sd, unsigned int seconds)
|
|
{
|
|
/* Idempotent. */
|
|
if (!sd->conn)
|
|
return;
|
|
|
|
log_debug(sd->log, "Shutting down");
|
|
|
|
/* No finished callback any more. */
|
|
sd->finished = NULL;
|
|
/* Don't free sd when we close connection manually. */
|
|
tal_steal(sd->ld, sd);
|
|
/* Close connection: should begin shutdown now. */
|
|
sd->conn = tal_free(sd->conn);
|
|
|
|
/* Do we actually want to wait? */
|
|
while (seconds) {
|
|
if (waitpid(sd->pid, NULL, WNOHANG) > 0) {
|
|
tal_del_destructor(sd, destroy_subd);
|
|
return;
|
|
}
|
|
sleep(1);
|
|
seconds--;
|
|
}
|
|
}
|
|
|
|
char *opt_subd_debug(const char *optarg, struct lightningd *ld)
|
|
{
|
|
ld->dev_debug_subdaemon = optarg;
|
|
return NULL;
|
|
}
|