core-lightning/common
Rusty Russell 723c16072a cleanups: feedback from Christian Decker review.
1. Hoist 7200 constant into the bolt12 heade2.
2. Make preimage the last createinvoice arg, so we could make it optional.
3. Check the validity of the preimage in createinvoice.
4. Always output used flag in listoffers.
5. Rename wallet offer iterators to offer_id iterators.
6. Fix paramter typos.
7. Rename `local_offer_id` parameter to `localofferid`.
8. Add reference constraints on local_offer_id db fields.
9. Remove cut/paste comment.
10. Clarify source of fatal() messages in wallet.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-12-15 12:05:02 +01:00
..
test tests: Move ecdh stub out of autogenerated stubs 2020-12-11 16:55:55 -06:00
addr.c addr: handle P2SH/P2PKH in scriptpubkey encoding 2019-11-13 03:31:20 +00:00
addr.h common: use tabs everywhere. 2020-02-05 14:19:12 +01:00
amount.c amount: correctly parse amount strings we generate 2020-10-21 19:34:39 +02:00
amount.h amount: add amount_msat_scale, amount_msat_ratio, amount_{msat,sat}_div 2020-08-06 09:36:47 +09:30
base32.c Remove tal_len, use tal_count() or tal_bytelen(). 2018-07-30 11:31:17 +02:00
base32.h common/base32: make this a simple tal-wrapper around ccan/base32. 2018-05-10 02:28:44 +00:00
base64.c common: remove b64_decode 2020-10-21 19:34:39 +02:00
base64.h common: remove b64_decode 2020-10-21 19:34:39 +02:00
bech32.c bech32: fix overflow bug. 2018-11-02 05:58:01 +00:00
bech32.h Use expected LIGHTNING_DIR_FILE_H define 2018-03-25 23:54:21 +00:00
bech32_util.c common/bech32_util: simple routines for checksumless bech32 charset usage. 2020-12-09 16:40:13 +10:30
bech32_util.h common/bech32_util: simple routines for checksumless bech32 charset usage. 2020-12-09 16:40:13 +10:30
bigsize.c wire: update to latest version of the spec. 2020-06-23 18:49:15 +02:00
bigsize.h Remove varint typedef for bigsize 2020-09-23 16:30:36 +09:30
bip32.c wire: move remaining bitcoin functions out to bitcoin/ files. 2020-05-18 14:51:12 +02:00
bip32.h wire: move remaining bitcoin functions out to bitcoin/ files. 2020-05-18 14:51:12 +02:00
blindedpath.c common/blindedpath: fix type of enctlv. 2020-12-15 12:05:02 +01:00
blindedpath.h common/blindedpath: EXPERIMENTAL creation of blinded paths. 2020-12-09 16:40:13 +10:30
blinding.c common: add blinding helpers. 2020-04-04 16:08:49 +10:30
blinding.h common: add blinding helpers. 2020-04-04 16:08:49 +10:30
bolt11.c bolt11: expose routine to parse bolt11 string except signature. 2020-12-15 12:05:02 +01:00
bolt11.h bolt11: expose routine to parse bolt11 string except signature. 2020-12-15 12:05:02 +01:00
bolt12.c common/bolt12: encode/decode for bolt12 offer, invoice_request and invoice 2020-12-09 16:40:13 +10:30
bolt12.h cleanups: feedback from Christian Decker review. 2020-12-15 12:05:02 +01:00
bolt12_merkle.c common/bolt12_merkle.h: experimental bolt 12 implementation. 2020-12-09 16:40:13 +10:30
bolt12_merkle.h common/bolt12_merkle.h: experimental bolt 12 implementation. 2020-12-09 16:40:13 +10:30
channel_config.c struct channel_config: use amount_sat / amount_msat. 2019-02-21 08:01:37 +00:00
channel_config.h bolt: update to BOLT spec changes (extract format + type specifications) 2019-07-16 06:10:58 +00:00
channel_id.c channel_id: add v2 channel_id derivtion helper 2020-09-09 19:54:20 +09:30
channel_id.h channel_id: add v2 channel_id derivtion helper 2020-09-09 19:54:20 +09:30
close_tx.c tx-psbt: pass in the witness script (if known) when adding an input 2020-06-11 13:13:13 +02:00
close_tx.h tx-psbt: pass in the witness script (if known) when adding an input 2020-06-11 13:13:13 +02:00
closing_fee.h closingd: configurable closing fee negotiation step 2020-04-07 13:52:48 +09:30
coin_mvt.c channel_id: save to database, dont derive from funding_txid 2020-09-09 19:54:20 +09:30
coin_mvt.h channel_id: save to database, dont derive from funding_txid 2020-09-09 19:54:20 +09:30
configdir.c doc: reorder --mainnet before --testnet 2020-10-15 17:57:51 +02:00
configdir.h config: explicitly disallow nonsensical options. 2019-11-23 22:42:34 +00:00
crypto_state.c crypto_state: move to its own file. 2017-10-20 18:31:32 +02:00
crypto_state.h crypto_state: move to its own file. 2017-10-20 18:31:32 +02:00
crypto_sync.c common: allow subdaemons to specify the node_id in status messages. 2019-11-18 04:50:22 +00:00
crypto_sync.h common/per_per_state: generalize lightningd/peer_comm Part 1 2019-06-04 01:29:39 +00:00
cryptomsg.c transition from status_trace() to status_debug 2019-09-10 02:02:51 +00:00
cryptomsg.h common/cryptomsg: remove unused async routines. 2018-09-28 04:14:28 +00:00
daemon.c common/daemon: remove notifiers on root at cleanup. 2020-12-07 14:23:59 +01:00
daemon.h Add missing extern qualifiers for gcc 10 2020-02-02 12:59:17 +10:30
daemon_conn.c status: suppress status_trace/status_debug messages if queue too long. 2019-05-03 11:42:48 +02:00
daemon_conn.h status: suppress status_trace/status_debug messages if queue too long. 2019-05-03 11:42:48 +02:00
decode_array.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
decode_array.h wire: update to latest version of the spec. 2020-06-23 18:49:15 +02:00
derive_basepoints.c developer: add --dev-force-channel-secrets. 2019-07-17 12:55:37 -05:00
derive_basepoints.h developer: add --dev-force-channel-secrets. 2019-07-17 12:55:37 -05:00
descriptor_checksum.c common: add a descriptor checksum computation module 2020-11-10 10:34:13 -06:00
descriptor_checksum.h common: add a descriptor checksum computation module 2020-11-10 10:34:13 -06:00
dev_disconnect.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
dev_disconnect.h Add DEVELOPER flag, set by default. 2017-10-26 12:53:09 +02:00
dijkstra.c common: cleanups suggested by Christian Decker's review. 2020-10-21 08:58:34 +10:30
dijkstra.h dijkstra: fix heap ordering. 2020-10-21 08:58:34 +10:30
ecdh.h common: generalize ecdh function. 2020-04-04 16:08:49 +10:30
ecdh_hsmd.c hsmd: convert to new wire generation style. 2020-08-25 12:53:13 +09:30
ecdh_hsmd.h common: generalize ecdh function. 2020-04-04 16:08:49 +10:30
errcode.h Use dedicated type for error codes 2020-01-31 06:02:47 +00:00
features.c features: add 'feature_bit_sub', which will subtract/unset bits 2020-10-26 21:31:24 -05:00
features.h features: add 'feature_bit_sub', which will subtract/unset bits 2020-10-26 21:31:24 -05:00
fee_states.c wire: move remaining bitcoin functions out to bitcoin/ files. 2020-05-18 14:51:12 +02:00
fee_states.h df: rename 'funder' to 'opener' 2020-05-04 10:22:26 +09:30
gossip_constants.h libplugin-pay: incorporate gossip store. 2020-10-21 08:58:34 +10:30
gossip_rcvd_filter.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
gossip_rcvd_filter.h common/gossip_rcvd_filter: cache for received gossip. 2019-09-06 14:35:01 +02:00
gossip_store.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
gossip_store.h gossip_store: make private channels more similar to channel_announcement 2020-10-21 08:58:34 +10:30
gossmap.c gossmap: helper to try to map x-only nodeid into 33-byte pubkey id. 2020-12-09 16:40:13 +10:30
gossmap.h gossmap: helper to try to map x-only nodeid into 33-byte pubkey id. 2020-12-09 16:40:13 +10:30
hash_u5.c common: use tabs everywhere. 2020-02-05 14:19:12 +01:00
hash_u5.h common: use tabs everywhere. 2020-02-05 14:19:12 +01:00
hmac.c common/sphinx: don't make copy to compute packet hmac. 2020-12-11 15:51:24 +01:00
hmac.h common/sphinx: don't make copy to compute packet hmac. 2020-12-11 15:51:24 +01:00
htlc.h htlc.h: move NUM_SIDES to define, not enum member 2020-11-23 12:21:33 -06:00
htlc_state.c Makefile: unify generated files definition. 2020-10-22 12:14:34 +10:30
htlc_state.h Fix a-vs-an typos 2018-02-08 22:49:34 +01:00
htlc_trim.c channeld, openingd: take into account option_anchor_outputs for fees. 2020-08-14 11:51:14 +09:30
htlc_trim.h channeld, openingd: take into account option_anchor_outputs for fees. 2020-08-14 11:51:14 +09:30
htlc_tx.c doc: update BOLT now option_anchor_outputs is merged. 2020-08-24 20:55:47 +09:30
htlc_tx.h doc: update BOLT now option_anchor_outputs is merged. 2020-08-24 20:55:47 +09:30
htlc_wire.c common/sphinx: make TOTAL_PACKET_SIZE a macro. 2020-12-11 15:51:24 +01:00
htlc_wire.h common/sphinx: make TOTAL_PACKET_SIZE a macro. 2020-12-11 15:51:24 +01:00
initial_channel.c channel_id: save to database, dont derive from funding_txid 2020-09-09 19:54:20 +09:30
initial_channel.h channel_id: save to database, dont derive from funding_txid 2020-09-09 19:54:20 +09:30
initial_commit_tx.c doc: update BOLT now option_anchor_outputs is merged. 2020-08-24 20:55:47 +09:30
initial_commit_tx.h openingd: pull out check_configs into a common place 2020-09-09 19:54:20 +09:30
io_lock.c common/io_lock: add helper to query if lock is taken. 2018-10-19 22:02:11 +00:00
io_lock.h common: use tabs everywhere. 2020-02-05 14:19:12 +01:00
iso4217.c common/iso4217: make find_iso4217 a little more usable. 2020-12-15 12:05:02 +01:00
iso4217.h common/iso4217: make find_iso4217 a little more usable. 2020-12-15 12:05:02 +01:00
json.c invoice: handle bolt12 strings if EXPERIMENTAL_FEATURES. 2020-12-15 12:05:02 +01:00
json.h invoice: handle bolt12 strings if EXPERIMENTAL_FEATURES. 2020-12-15 12:05:02 +01:00
json_command.h json_command: command_fail_badparam helper. 2020-09-02 09:46:37 +09:30
json_helpers.c bitcoin/tx: fix type of outpoint (n is a u32), simplify json_to_outpoint 2020-12-09 06:56:21 +10:30
json_helpers.h txprepare: Use param_outpoint_arr helper to validate input 2020-12-09 06:56:21 +10:30
json_stream.c common/json_stream: add generic double-cr helper. 2020-10-23 13:53:16 +10:30
json_stream.h common/json_stream: add generic double-cr helper. 2020-10-23 13:53:16 +10:30
json_tok.c common/json_tok: minor cleanup to bitcoin_outpoint array parsing. 2020-12-09 06:56:21 +10:30
json_tok.h json: Add two param functions to parse string arrs and outpoint arrs 2020-12-09 06:56:21 +10:30
jsonrpc_errors.h lightningd: createinvoice low-level invoice creation command. 2020-12-15 12:05:02 +01:00
key_derive.c doc: update BOLT now option_anchor_outputs is merged. 2020-08-24 20:55:47 +09:30
key_derive.h headers: fix up header idempotent lines. 2017-08-29 17:54:14 +02:00
keyset.c doc: update BOLT now option_anchor_outputs is merged. 2020-08-24 20:55:47 +09:30
keyset.h derive_keyset: don't rotate key for remote iff option_static_remotekey. 2019-09-10 16:18:25 -05:00
Makefile common/blindedpath: EXPERIMENTAL creation of blinded paths. 2020-12-09 16:40:13 +10:30
memleak.c common/memleak: simplify and document API. 2020-09-23 13:52:49 +09:30
memleak.h common/memleak: simplify and document API. 2020-09-23 13:52:49 +09:30
msg_queue.c common: tal_dup_talarr() helper. 2020-02-27 14:16:16 +10:30
msg_queue.h status: suppress status_trace/status_debug messages if queue too long. 2019-05-03 11:42:48 +02:00
node_id.c bitcoin/pubkey: add pubkey32 primitive for xonly pubkey types. 2020-12-09 16:40:13 +10:30
node_id.h bitcoin/pubkey: add pubkey32 primitive for xonly pubkey types. 2020-12-09 16:40:13 +10:30
onion.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
onion.h common/onion: add blinding and enctlv encoding. 2020-04-14 12:51:18 +09:30
onionreply.c wire: move towire/fromwire_short_channel_id out to bitcoin/short_channel_id.c 2020-05-18 14:51:12 +02:00
onionreply.h common: add struct onionreply 2020-01-23 16:17:42 +10:30
overflows.h The overflow check mul_overflows_s64(int64_t, int64_t) overflows and triggers UB :-) Remove it 2018-03-27 23:18:48 +00:00
param.c cleanup: Remove stdio header from param.c 2020-12-09 06:56:21 +10:30
param.h common: use tabs everywhere. 2020-02-05 14:19:12 +01:00
peer_billboard.c common: convert to new wire generation style. 2020-08-25 12:53:13 +09:30
peer_billboard.h common: peer_billboard() helper for updating the billboard. 2018-02-23 18:02:00 +01:00
peer_failed.c common: convert to new wire generation style. 2020-08-25 12:53:13 +09:30
peer_failed.h channeld: treat all incoming errors as "soft", so we retry. 2019-12-13 16:36:18 +01:00
peer_status_wire.csv common/channel_id: move channel_id into its own file. 2020-05-18 14:51:12 +02:00
peer_status_wiregen.c utf8: handle UTF-8 arrays. 2020-12-09 16:40:13 +10:30
peer_status_wiregen.h utf8: handle UTF-8 arrays. 2020-12-09 16:40:13 +10:30
penalty_base.c amount: use initializers everywhere. 2020-08-06 09:36:47 +09:30
penalty_base.h watchtower: Add a struct containing the penalty base information 2020-05-07 15:05:39 +09:30
per_peer_state.c Move gossip_constants.h into common/ 2019-09-25 04:01:56 +00:00
per_peer_state.h developer: consolidiate gossip timing options into one --dev-fast-gossip. 2019-09-20 06:55:00 +00:00
permute_tx.c psbt: remove input_amounts from bitcoin tx 2020-06-11 13:13:13 +02:00
permute_tx.h tx: Change permute_{inputs,outputs} to sort both old and new txs 2019-04-08 00:00:00 +00:00
ping.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
ping.h pong: embed version string into ping replies if DEVELOPER=1. 2018-02-22 12:24:26 +01:00
private_channel_announcement.c common/private_channel_announcement: don't include wire/peer_wiregen directly 2020-12-15 09:28:56 +10:30
private_channel_announcement.h gossip_store: make private channels more similar to channel_announcement 2020-10-21 08:58:34 +10:30
psbt_internal.c df: incorporate a few spec changes -- serial_id is now 64-bits 2020-10-27 19:52:05 -05:00
psbt_internal.h df: finalize redeemscript at the same time as witness stack 2020-10-26 13:04:42 +10:30
psbt_open.c mfc-psbt: mark all of our inputs as "ours", then only sign those 2020-11-23 12:41:05 -06:00
psbt_open.h mfc-psbt: mark all of our inputs as "ours", then only sign those 2020-11-23 12:41:05 -06:00
pseudorand.c common: expose pseudorand_double 2019-04-16 21:22:13 +00:00
pseudorand.h common: expose pseudorand_double 2019-04-16 21:22:13 +00:00
random_select.c common/random_select: central place for reservoir sampling. 2020-08-28 10:56:50 +09:30
random_select.h Apply @cdecker typo suggestions from code review 2020-08-28 10:56:50 +09:30
read_peer_msg.c Makefile: use generic rules to make spec-derived sources. 2020-08-31 21:33:26 -05:00
read_peer_msg.h channeld: treat all incoming errors as "soft", so we retry. 2019-12-13 16:36:18 +01:00
route.c common: cleanups suggested by Christian Decker's review. 2020-10-21 08:58:34 +10:30
route.h route: return NULL if destination is unreachable. 2020-10-21 08:58:34 +10:30
setup.c common: check for outstanding taken() pointers in common_shutdown. 2020-12-02 12:55:09 +10:30
setup.h setup: create a common setup which will handle the wally-context 2020-05-19 13:35:42 +09:30
socket_close.c closingd: Ensure proper closing of TCP socket. 2018-05-09 04:43:21 +00:00
socket_close.h closingd: Ensure proper closing of TCP socket. 2018-05-09 04:43:21 +00:00
sphinx.c common/sphinx: remove assertion that onions we parse must be 1366 bytes. 2020-12-11 15:51:24 +01:00
sphinx.h common/sphinx: make onionpacket.routinginfo a dynamic member. 2020-12-11 15:51:24 +01:00
status.c Makefile: use generic rules to make spec-derived sources. 2020-08-31 21:33:26 -05:00
status.h common: allow subdaemons to specify the node_id in status messages. 2019-11-18 04:50:22 +00:00
status_levels.c common: add routines for log level names. 2020-10-23 13:53:16 +10:30
status_levels.h common: add routines for log level names. 2020-10-23 13:53:16 +10:30
status_wire.c status: generate messages rather than marshal/unmarshal manually. 2018-02-08 19:07:12 +01:00
status_wire.csv wire: move remaining bitcoin functions out to bitcoin/ files. 2020-05-18 14:51:12 +02:00
status_wire.h status: generate messages rather than marshal/unmarshal manually. 2018-02-08 19:07:12 +01:00
status_wiregen.c utf8: handle UTF-8 arrays. 2020-12-09 16:40:13 +10:30
status_wiregen.h utf8: handle UTF-8 arrays. 2020-12-09 16:40:13 +10:30
subdaemon.c common: allow subdaemons to specify the node_id in status messages. 2019-11-18 04:50:22 +00:00
subdaemon.h common: reduce header differences for DEVELOPER vs non-DEVELOPER. 2019-09-06 14:35:01 +02:00
timeout.c utils: remove tal_tmpctx altogether, use global. 2018-03-16 00:16:10 +00:00
timeout.h headers: fix up header idempotent lines. 2017-08-29 17:54:14 +02:00
tx_roles.h tx_roles: pull up roles, rename 2020-10-20 12:50:31 +10:30
type_to_string.c type_to_string: return const char *. 2019-02-21 00:44:57 +00:00
type_to_string.h bitcoin/pubkey: add pubkey32 primitive for xonly pubkey types. 2020-12-09 16:40:13 +10:30
utils.c common/utils: simple utf8 helpers. 2020-12-02 10:38:04 +10:30
utils.h common/utils: simple utf8 helpers. 2020-12-02 10:38:04 +10:30
utxo.c fundpsbt/utxopsbt: new min_witness_weight param 2020-12-02 14:19:08 +10:30
utxo.h fundpsbt/utxopsbt: new min_witness_weight param 2020-12-02 14:19:08 +10:30
version.c Makefile: unify generated files definition. 2020-10-22 12:14:34 +10:30
version.h Onboarding: Make log output texts friendlier to new users 2018-01-29 03:22:27 +00:00
wallet.c wallet: Rip out the txtypes type in favor of enum wallet_tx_type 2019-06-08 02:58:27 +00:00
wallet.h wallet: Add transaction annotation type 2019-10-07 20:03:24 -05:00
wire_error.c Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
wire_error.h common: fix up BOLT 1 references. 2018-06-18 12:31:09 +02:00
wireaddr.c common: use tabs everywhere. 2020-02-05 14:19:12 +01:00
wireaddr.h common/wireaddr: don't include lightningd/lightningd. 2020-02-27 14:16:16 +10:30