mirror of
https://github.com/ElementsProject/lightning.git
synced 2024-11-19 18:11:28 +01:00
55173a56b7
Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2
37 lines
1.1 KiB
C
37 lines
1.1 KiB
C
#ifndef LIGHTNING_LIGHTNINGD_PAY_H
|
|
#define LIGHTNING_LIGHTNINGD_PAY_H
|
|
#include "config.h"
|
|
#include <ccan/short_types/short_types.h>
|
|
#include <common/errcode.h>
|
|
|
|
struct htlc_out;
|
|
struct lightningd;
|
|
struct onionreply;
|
|
struct preimage;
|
|
struct sha256;
|
|
struct json_stream;
|
|
struct wallet_payment;
|
|
struct routing_failure;
|
|
|
|
void payment_succeeded(struct lightningd *ld, struct htlc_out *hout,
|
|
const struct preimage *rval);
|
|
|
|
void payment_failed(struct lightningd *ld, const struct htlc_out *hout,
|
|
const char *localfail);
|
|
|
|
/* Inform payment system to save the payment. */
|
|
void payment_store(struct lightningd *ld, struct wallet_payment *payment);
|
|
|
|
/* This json will be also used in 'sendpay_success' notifictaion. */
|
|
void json_add_payment_fields(struct json_stream *response,
|
|
const struct wallet_payment *t);
|
|
|
|
/* This json will be also used in 'sendpay_failure' notifictaion. */
|
|
void json_sendpay_fail_fields(struct json_stream *js,
|
|
const struct wallet_payment *t,
|
|
errcode_t pay_errcode,
|
|
const struct onionreply *onionreply,
|
|
const struct routing_failure *fail);
|
|
|
|
#endif /* LIGHTNING_LIGHTNINGD_PAY_H */
|