Rusty Russell 9b8fe618f6 pay: remove cmd pointer from htlc_out. ... Maintaining it was always fraught, since the command could go away if the JSON RPC died. Most recently, it was broken again on shutdown (see below). In future we may allow pay commands to block on previous payments, so it won't even be a 1:1 mapping. Generalize it: keep commands in a simple list and do a lookup when a payment fails/succeeds. Valgrind error file: valgrind-errors.5732 ==5732== Invalid read of size 8 ==5732== at 0x4149FD: remove_cmd_from_hout (pay.c:292) ==5732== by 0x468BAB: notify (tal.c:237) ==5732== by 0x469077: del_tree (tal.c:400) ==5732== by 0x4690C7: del_tree (tal.c:410) ==5732== by 0x46948A: tal_free (tal.c:509) ==5732== by 0x40F1EA: main (lightningd.c:362) ==5732== Address 0x69df148 is 1,512 bytes inside a block of size 1,544 free'd ==5732== at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==5732== by 0x469150: del_tree (tal.c:421) ==5732== by 0x46948A: tal_free (tal.c:509) ==5732== by 0x4198F2: free_htlcs (peer_control.c:1281) ==5732== by 0x40EBA9: shutdown_subdaemons (lightningd.c:209) ==5732== by 0x40F1DE: main (lightningd.c:360) ==5732== Block was alloc'd at ==5732== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==5732== by 0x468C30: allocate (tal.c:250) ==5732== by 0x4691F7: tal_alloc_ (tal.c:448) ==5732== by 0x40A279: new_htlc_out (htlc_end.c:143) ==5732== by 0x41FD64: send_htlc_out (peer_htlcs.c:397) ==5732== by 0x41511C: send_payment (pay.c:388) ==5732== by 0x41589E: json_sendpay (pay.c:513) ==5732== by 0x40D9B1: parse_request (jsonrpc.c:600) ==5732== by 0x40DCAC: read_json (jsonrpc.c:667) ==5732== by 0x45C706: next_plan (io.c:59) ==5732== by 0x45D1DD: do_plan (io.c:387) ==5732== by 0x45D21B: io_ready (io.c:397) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>		2018-02-02 20:33:49 +01:00
..
test	wallet: abstract away delayed entry of wallet_payment.	2018-01-17 23:55:35 +01:00
.gitignore	wallet: Create and manage a sqlite3 database for the wallet	2017-06-06 09:16:10 +09:30
db.c	pay: Save nodes and channels used on route to payment.	2018-02-01 00:46:06 +00:00
db.h	pay: Save nodes and channels used on route to payment.	2018-02-01 00:46:06 +00:00
invoices.c	delinvoice: fixes.	2018-01-19 22:23:45 +00:00
invoices.h	Fix typos	2018-01-18 20:50:07 +01:00
Makefile	invoices: Extensive reorganization of invoice system.	2018-01-16 13:03:54 +01:00
wallet.c	pay: remove cmd pointer from htlc_out.	2018-02-02 20:33:49 +01:00
wallet.h	pay: Save nodes and channels used on route to payment.	2018-02-01 00:46:06 +00:00
walletrpc.c	jsonprc: make json_get_params() fail the command, for better error reporting.	2018-02-02 00:05:00 +01:00
walletrpc.h	walletrpc: Implemented the withdrawal flow	2017-06-23 16:02:20 +09:30