mirror of
https://github.com/ElementsProject/lightning.git
synced 2025-02-22 22:45:27 +01:00
01cd605cb1
We were getting the following message in test_feerate_stress: ``` 2024-07-08T02:15:45.5663941Z lightningd-2 2024-07-08T02:13:45.696Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-connectd: Peer did not close, forcing close ``` I can reproduce it locally if I run the test enough, and finally found the issue by printing the status of the fd when we time it out (using routines from connectd.c). The peer fd alternates between reading and writing. When we go to discard it, we wake the write queue, so write_to_peer() get called. It won't shutdown the socket if there are still subds attached, and will wait again for a read. The last subd exit has to also wake the write queue if we're draining, so it can do the io_sock_shutdown. Otherwise, we hit the timeout, causing the message above. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> |
||
|---|---|---|
| .. | ||
| test | ||
| connectd.c | ||
| connectd.h | ||
| connectd_gossipd_wire.csv | ||
| connectd_wire.csv | ||
| gossip_rcvd_filter.c | ||
| gossip_rcvd_filter.h | ||
| gossip_store.c | ||
| gossip_store.h | ||
| handshake.c | ||
| handshake.h | ||
| Makefile | ||
| multiplex.c | ||
| multiplex.h | ||
| netaddress.c | ||
| netaddress.h | ||
| onion_message.c | ||
| onion_message.h | ||
| peer_exchange_initmsg.c | ||
| peer_exchange_initmsg.h | ||
| sha1.c | ||
| sha1.h | ||
| tor.c | ||
| tor.h | ||
| tor_autoservice.c | ||
| tor_autoservice.h | ||
| websocketd.c | ||