Rusty Russell d9b1e69243 dual_funding: don't steal inflight field in update_channel_from_inflight. ... If we call update_channel_from_inflight *twice* with the same inflight, we will get bad results. Using tal_steal() here was a premature optimization: ``` Valgrind error file: valgrind-errors.496395 ==496395== Invalid read of size 8 ==496395== at 0x22A9D3: to_tal_hdr (tal.c:174) ==496395== by 0x22B4B5: tal_steal_ (tal.c:498) ==496395== by 0x16A13D: update_channel_from_inflight (peer_control.c:1225) ==496395== by 0x16A4C7: funding_depth_cb (peer_control.c:1299) ==496395== by 0x182807: txw_fire (watch.c:232) ==496395== by 0x182AA9: watch_topology_changed (watch.c:300) ==496395== by 0x1290ED: updates_complete (chaintopology.c:624) ==496395== by 0x129BF4: get_new_block (chaintopology.c:835) ==496395== by 0x125EEF: getrawblockbyheight_callback (bitcoind.c:362) ==496395== by 0x176ECC: plugin_response_handle (plugin.c:584) ==496395== by 0x1770F5: plugin_read_json_one (plugin.c:690) ==496395== by 0x1772D9: plugin_read_json (plugin.c:735) ==496395== Address 0x89fbb08 is 24 bytes inside a block of size 104 free'd ==496395== at 0x483CA3F: free (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==496395== by 0x22B193: del_tree (tal.c:421) ==496395== by 0x22B461: tal_free (tal.c:486) ==496395== by 0x16A123: update_channel_from_inflight (peer_control.c:1223) ==496395== by 0x16A4C7: funding_depth_cb (peer_control.c:1299) ==496395== by 0x182807: txw_fire (watch.c:232) ==496395== by 0x182AA9: watch_topology_changed (watch.c:300) ==496395== by 0x1290ED: updates_complete (chaintopology.c:624) ==496395== by 0x129BF4: get_new_block (chaintopology.c:835) ==496395== by 0x125EEF: getrawblockbyheight_callback (bitcoind.c:362) ==496395== by 0x176ECC: plugin_response_handle (plugin.c:584) ==496395== by 0x1770F5: plugin_read_json_one (plugin.c:690) ==496395== Block was alloc'd at ==496395== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==496395== by 0x22AC1C: allocate (tal.c:250) ==496395== by 0x22B1DD: tal_alloc_ (tal.c:428) ==496395== by 0x22B3A6: tal_alloc_arr_ (tal.c:471) ==496395== by 0x22C094: tal_dup_ (tal.c:805) ==496395== by 0x12B274: new_inflight (channel.c:187) ==496395== by 0x136D4C: wallet_commit_channel (dual_open_control.c:1260) ==496395== by 0x13B084: handle_commit_received (dual_open_control.c:2839) ==496395== by 0x13B6AF: dual_opend_msg (dual_open_control.c:2976) ==496395== by 0x1809FF: sd_msg_read (subd.c:553) ==496395== by 0x218F5D: next_plan (io.c:59) ==496395== by 0x219B65: do_plan (io.c:407) ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>		2022-02-08 11:15:52 +10:30
..
test	connectd: don't received useless peer fd if we're told to send final msg.	2022-02-08 11:15:52 +10:30
.gitignore	Ignore all the deamon inside the git history	2021-10-28 15:51:38 +02:00
bitcoind.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
bitcoind.h	common: use bitcoin_outpoint.	2021-10-15 12:09:36 +02:00
chaintopology.c	balance-snaps: add a balance_snapshot event; fires after first catchup	2021-12-28 04:42:42 +10:30
chaintopology.h	cleanup: remove unneeded includes in header files.	2021-09-17 09:43:22 +09:30
channel_control.c	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
channel_control.h	channeld: keep local copy of latest channel_update for errors.	2022-02-08 11:15:52 +10:30
channel_state.h	channel-state: add two new states, for dualopend	2021-01-10 13:44:04 +01:00
channel.c	gossipd: infrastructure to tell lightningd about local channel updates.	2022-02-08 11:15:52 +10:30
channel.h	lightningd: tell gossipd when we use the channel_update.	2022-02-08 11:15:52 +10:30
closing_control.c	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
closing_control.h	patch lightningd-peer-fds.patch	2022-01-20 15:24:06 +10:30
coin_mvts.c	common/coin_mvt: clean up API a little.	2021-12-30 14:36:55 +10:30
coin_mvts.h	coin_mvt: tiny, dont import lightningd header	2022-02-07 13:02:09 +10:30
connect_control.c	connectd: remove second gossip fd.	2022-02-08 11:15:52 +10:30
connect_control.h	connectd: remove second gossip fd.	2022-02-08 11:15:52 +10:30
datastore.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
dual_open_control.c	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
dual_open_control.h	patch lightningd-peer-fds.patch	2022-01-20 15:24:06 +10:30
gossip_control.c	connectd: remove second gossip fd.	2022-02-08 11:15:52 +10:30
gossip_control.h	connectd: remove second gossip fd.	2022-02-08 11:15:52 +10:30
hsm_control.c	lightningd: support hsm error code	2021-12-15 12:24:54 +10:30
hsm_control.h	cleanup: remove unneeded includes in header files.	2021-09-17 09:43:22 +09:30
htlc_end.c	global: use tal_dup_or_null().	2021-12-30 14:36:55 +10:30
htlc_end.h	coin_mvt: record fees for an outbound htlc	2021-12-28 04:42:42 +10:30
htlc_set.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
htlc_set.h	Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES	2020-09-08 09:42:00 +09:30
invoice.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
invoice.h	Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES	2020-09-08 09:42:00 +09:30
io_loop_with_timers.c	common: cleanup unsused parameter in timer_expired()	2021-12-14 09:33:10 +10:30
io_loop_with_timers.h	lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it.	2019-05-31 17:57:10 +02:00
json.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
json.h	common: hoist param_bitcoin_address where plugins can use it.	2020-08-11 08:39:24 +09:30
jsonrpc.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
jsonrpc.h	lightningd: cleanup, freeing jsonrpc in shutdown cannot trigger db write's anymore	2021-11-30 13:34:44 +10:30
lightningd.c	lightningd: clean up subds before freeing HTLCs.	2022-02-08 11:15:52 +10:30
lightningd.h	subd: fix waitpid properly.	2022-01-25 06:26:52 +10:30
log_status.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
log_status.h	cleanup: remove unneeded includes in header files.	2021-09-17 09:43:22 +09:30
log.c	global: use tal_dup_or_null().	2021-12-30 14:36:55 +10:30
log.h	log: don't leak log prefixes.	2021-11-27 10:38:13 +10:30
Makefile	connectd: handle pings and pongs.	2022-02-08 11:15:52 +10:30
memdump.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
memdump.h	cleanup: remove unneeded includes in header files.	2021-09-17 09:43:22 +09:30
notification.c	coin_moves: add an 'originating_account' field	2022-01-26 13:34:45 +10:30
notification.h	balance snap: first pass	2021-12-28 04:42:42 +10:30
offer.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
onchain_control.c	lightningd: clean up subds before freeing HTLCs.	2022-02-08 11:15:52 +10:30
onchain_control.h	onchaind: remove 'is_replay' logic	2021-12-28 04:42:42 +10:30
onion_message.c	connectd: handle onion messages.	2022-02-08 11:15:52 +10:30
onion_message.h	common: remove support for pre v0.10.2 onionmessages.	2021-12-01 05:44:28 +10:30
opening_common.c	lightningd: clean up subds before freeing HTLCs.	2022-02-08 11:15:52 +10:30
opening_common.h	patch lightningd-peer-fds.patch	2022-01-20 15:24:06 +10:30
opening_control.c	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
opening_control.h	patch lightningd-peer-fds.patch	2022-01-20 15:24:06 +10:30
options.c	options: only allow one DNS announcement	2022-01-02 16:01:38 +01:00
options.h	cleanup: remove unneeded includes in header files.	2021-09-17 09:43:22 +09:30
pay.c	lightningd: use our cached channel_update for errors instead of asking gossipd.	2022-02-08 11:15:52 +10:30
pay.h	lightningd: use our cached channel_update for errors instead of asking gossipd.	2022-02-08 11:15:52 +10:30
peer_control.c	dual_funding: don't steal inflight field in update_channel_from_inflight.	2022-02-08 11:15:52 +10:30
peer_control.h	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
peer_fd.c	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
peer_fd.h	subdaemons: remove gossipd fd from per-peer daemons.	2022-02-08 11:15:52 +10:30
peer_htlcs.c	lightningd: use our cached channel_update for errors instead of asking gossipd.	2022-02-08 11:15:52 +10:30
peer_htlcs.h	lightningd: use our cached channel_update for errors instead of asking gossipd.	2022-02-08 11:15:52 +10:30
ping.c	connectd: handle pings and pongs.	2022-02-08 11:15:52 +10:30
plugin_control.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
plugin_control.h	plugins: add command field to subcommand output.	2021-06-25 09:49:33 +09:30
plugin_hook.c	plugins: simplify shutdown loop, simply close the db	2021-12-14 09:33:10 +10:30
plugin_hook.h	cleanup: remove unneeded includes in header files.	2021-09-17 09:43:22 +09:30
plugin.c	lightningd: cleanup obsolete plugins->shutdown flag	2021-12-14 09:33:10 +10:30
plugin.h	lightningd: cleanup obsolete plugins->shutdown flag	2021-12-14 09:33:10 +10:30
routehint.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
routehint.h	invoice: overhaul routehints to use topology.listincoming, cleanup.	2021-06-16 10:29:17 +09:30
signmessage.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
subd.c	lightningd: clean up subds before freeing HTLCs.	2022-02-08 11:15:52 +10:30
subd.h	lightningd: clean up subds before freeing HTLCs.	2022-02-08 11:15:52 +10:30
watch.c	check: make sure all files outside contrib/ include "config.h" first.	2021-12-06 10:05:39 +10:30
watch.h	common: use bitcoin_outpoint.	2021-10-15 12:09:36 +02:00