mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-07 14:29:33 +01:00
Code Issues Projects Releases Wiki Activity
9,601 Commits 34 Branches 196 Tags 136 MiB
fc64ebdb53
Commit Graph

132 Commits

Author SHA1 Message Date
niftynei
fc64ebdb53 dual-funding: don't not update the state! log the issue and move on with 
with your life
 2021-03-17 10:25:18 +10:30
niftynei
dd696a7c05 df: move from warning to unusual 
There are perfectly valid reasons for us to not have a command on return
(something went boom while sending them our sigs and we've now gotten
their sigs during a reconnect and subsequently broadcast the tx)
 2021-03-17 10:25:18 +10:30
niftynei
61df08c50d df-broadcasts: use an impermanent marker to make sure we've sent things 
This can result in us logging a warning if we've 1) dropped their sigs
response, 2) only us (the opener) added inputs, 3) and we broadcast on
their reconnect (when they retransmit their sigs)
 2021-03-17 10:25:18 +10:30
niftynei
bec96a6c5b df: add openchannel_abort command 
Allows us to clean up an in-progress open that we won't be completing

Changelog-Added: EXPERIMENTAL JSON-RPC: Permit user-initiated aborting of in-progress opens. Only valid for not-yet-committed opens and RBF-attempts
 2021-03-15 14:08:44 +10:30
niftynei
015a0555d0 df: nit, update to use proper helper json function for channel_id 2021-03-15 14:08:44 +10:30
niftynei
8182e9cea4 df: update the openchannel2 parameter 'accepter' -> 'our' 
The `rbf_channel` hook uses `our_funding_msat`, which is a nicer
and more easily understood than the `openchannel2`
`accepter_funding_msat`.

This updates the `openchannel2` hook to use the same nomenclature as
`rbf_channel`.
 2021-03-12 14:00:19 +10:30
niftynei
a60d652517 df: add missing check for already set scriptpubkey 
Noticed while adding the documentation for the hook.
 2021-03-12 14:00:19 +10:30
niftynei
52b5dbb01d df: add doc for channel_open_failed notification 
When a channel fails, send out a notification.

We were missing this notification in one case, which has been added.
 2021-03-12 14:00:19 +10:30
niftynei
fc9e72b62b df-doc: add docs for openchannel_bump, more checks for valid psbt 
Add docs for openchannel_bump, plus some checks that were missed for
verifying the amount is valid.
 2021-03-12 14:00:19 +10:30
niftynei
a648ec827a df-doc: update error codes, make sure they're correct 2021-03-12 14:00:19 +10:30
niftynei
26e4bae9ce df: fail channel if peer sends witnesses that aren't paid for 
The receiving node: ...
      - MUST fail the channel if:
        - the `witness_stack` weight lowers the effective `feerate`
          below the agreed upon transaction `feerate`
 2021-03-09 14:55:05 +10:30
niftynei
31e3bdb42d df-spec: consolidate dual-funding patches, update feerate protocol 
We consolidate to the latest/singular RFC patch for dual-funding, so
there's just a single patchfile for the change. Plus we move back to the
opener setting the desired feerate, the accepter merely declines to
participate if they disagree with the set rate.
 2021-03-09 14:55:05 +10:30
niftynei
71164799f9 dual-fund: remove all references to PODLEs 
We're punting on PODLE's for v1 of dual-funded channels
 2021-03-09 14:55:05 +10:30
niftynei
8cc2919884 connectd: clean up the channel stuffs when we get a reconnect 
If they've disconnected/reconnected we need to terminate all the
inflight stuff, plus go ahead and call 'disconnect' plugin trigger etc.
 2021-03-06 15:03:56 +10:30
niftynei
97e64915c5 df: add (over zealous?) note about the usage of psbt_has_req_fields 
Requested-In-Part-By: Rusty Russell @rustyrussell
 2021-03-06 15:03:56 +10:30
niftynei
fc411a5925 df-memleak: expose memleak error and fix 
We were getting a memleak error that the open_attempt isnt' being
cleaned up in test_rbf_reconnect_tx_construct. I had some trouble
reproducing it, so I removed the reliance on using `tmpctx` to clean it
up and was more surgical about cleaning it up inline.
 2021-03-06 15:03:56 +10:30
niftynei
e0a2d47903 df-rbf: reconnection tests (init_rbf + ack_rbf) 2021-03-06 15:03:56 +10:30
niftynei
07153bff6a df: cleanup error handling on lightningd side 
Make existing methods understand how unsaved channels work, re-work
errors so that we handle everything appropriately
 2021-03-06 15:03:56 +10:30
niftynei
6c76dd338e channel: move inflight + feerate methods to channel.c 
Need these more accessible for next patch, which moves the next_feerate
info into listpeers
 2021-03-06 15:03:56 +10:30
niftynei
a23277af57 listpeers: include info on channels that are in-process 
Channels that we're in negotiation for, but don't have a commitment
transaction saved for yet.
 2021-03-06 15:03:56 +10:30
niftynei
ff069ff924 rbf: consolidate failure paths, use "warnings" 
We move over to the new "warning" paradigm, instead of using
an "rbf_fail" message.

Every failure is either a warning or an error; on warnings we
hang up and reconnect later, effectively resetting the state.
 2021-03-06 15:03:56 +10:30
niftynei
4fb95a9350 df-rbf: separate first-time channel save from update (RBF) 
We can't "first save" a channel twice; instead we split in two and just
update the underlying channel on subsequent passes (RBFs)
 2021-03-06 15:03:56 +10:30
niftynei
f22fed3fd5 df-rbf: only permit the channel initiator to init RBF 
We're *mostly* set up for both sides doing RBF, except that it reverses
the callback flow (using the plugin vs RPC calls) and we're not
currently smart enough to flip between them gracefully
 2021-03-06 15:03:56 +10:30
niftynei
a0cb7bd9b4 df: update reserve calculation 
We can use the funding amount to derive the reserve requirement.
 2021-03-06 15:03:56 +10:30
niftynei
2719ff8c3b df-rbf: handle rbf failures in lightningd 2021-03-06 15:03:56 +10:30
niftynei
d47358848f df-rbf: init an rbf for real, using openchannel_bumpfee 
Reorg a bit of the RBF code so we use the same codepaths for we-init vs
they-init starts.
 2021-03-06 15:03:56 +10:30
niftynei
063948d51a df-feerates: send back original + last known feerates 
For calculating the next RBF attempt's feerate, we need some historical
information about the feerate used for this channel
 2021-03-03 16:19:04 -06:00
niftynei
cf170c3909 df: allow for RBF_INIT in sigs states 2021-03-03 16:19:04 -06:00
niftynei
02d99acca1 dualopen: check that peer is connected for json calls 
Before we start trying to talk to the peer, check that they're
connected.
 2021-03-03 16:19:04 -06:00
niftynei
d8221aae76 df: update channel_id when opening; closing; disconnecting 
We were missing the channel_id for accepter opens; it's also a good idea
to reset it to 0xFF when we disconnect totally
 2021-03-03 16:19:04 -06:00
niftynei
6407ad334f df, channel: if a channel reconnects, but it's "unsaved" still 
Go ahead and start dualopend, but as a fresh instance.
 2021-03-03 16:19:04 -06:00
niftynei
779067d74c df: check inflights when deciding whether or not to allow command 
We were missing the inflight state checks before allowing to proceed
with a command.
 2021-03-03 16:19:04 -06:00
niftynei
da81d4bced channel: skip unsaved channels 
Now that "peer->channels" contains `unsaved` channels, skip overthem
where appropriate
 2021-03-03 16:19:04 -06:00
niftynei
de3599e98a subd: remove ctype (channel_type) 
We only needed the type check for dual_open, since it was the only
subdaemon path that used two 'types' in the subd->channel field.
 2021-03-03 16:19:04 -06:00
niftynei
1e9a900918 df: start of RPC for bumping the fee! 
Doesn't call into dualopend yet
 2021-03-03 16:19:04 -06:00
niftynei
d49db8ad41 df: do the right thing, now that we have a cancellation routine 
removes a fixme
 2021-03-03 16:19:04 -06:00
niftynei
3da2ae4d30 df: move to inflights for sigs/openchannel_signed parts of flow 
We create an inflight once we get the commitment tx for a channel
instead of once we get the funding transaction signatures
 2021-03-03 16:19:04 -06:00
niftynei
8b0e88dfb3 df: move initialization over to unsaved channel 
uncommitted_channel -> channel (but unsaved)
 2021-03-03 16:19:04 -06:00
niftynei
0951e2c941 df: get rid of unnecessary struct commit_rcvd 2021-03-03 16:19:04 -06:00
niftynei
95e81ce82c df: helper to find the last (most recent) inflight for a channel 2021-03-03 16:19:04 -06:00
niftynei
628f9df320 df: consolidate callbacks for opener/accepter, move to open_attempt 2021-03-03 16:19:04 -06:00
niftynei
bfb862564e df: method for disconnecting an *unsaved* channel 
Since we're moving over to "unsaved channels" instead of
"uncommitted_channel" struct, we need a new utility to disconnect this
channe
 2021-03-03 16:19:04 -06:00
niftynei
1786fcbbdc df: migrate from "uncommitted_channel" to "open_attempt" 
We're going to move over to "unsaved channels" instead of using a
separate "uncommitted_channel" struct. This means a peer might have a
channel that's not saved to the database yet in its channel list
 2021-03-03 16:19:04 -06:00
niftynei
6474779e38 df-rbf: hook for rbf_init attempt, called "rbf_channel" 
When we get an RBF request, we ask the/a plugin what they'd like to do
about it. This pipes the request through to the plugin
 2021-03-03 16:19:04 -06:00
niftynei
50b8655cbe channel: remove 'uncommitted_channel' from channel lookup 
We're going to be removing "uncommitted_channel" from v2 open stat
 2021-03-03 12:28:22 +10:30
niftynei
4baa10ef68 channel: remove psbt and remote_tx_sigs 
We just added this, but we've migrated them to the "inflight" struct
instead, as they actually pertain to an single inflight open attempt
 2021-03-03 12:28:22 +10:30
niftynei
99123ddbe4 dual-funding, rbf: reject RBFs that will fail the total-fee rule 
RBFs must have a total fee greater than the last successful RBF attempt
 2021-03-03 12:28:22 +10:30
lisa neigut
0d8351155e df-rbf: validate that the candidate funding transaction is valid 
We need to make sure that there's at least one input that's represented
in every single RBF-attempt for this channel, to prevent "parallel"
subsequent RBFs from succeeding/opening (the multi-channel backdoor?!)
 2021-03-03 12:28:22 +10:30
niftynei
22078262f0 df-reinit: pass back channel_flags 
We should also restore the channel_flags field on reinit; we use them if
we do an RBF after a reconnection
 2021-03-03 12:28:22 +10:30
niftynei
a489f92ee8 df-rbf: start of handling an incoming RBF attempt from peer 
A peer init's an RBF, we start handling it
 2021-03-03 12:28:22 +10:30