Christian Decker
c38afc5512
tx: Switch to amount_sat for fee computations
...
Suggested-by: Rusty Russell <@rustyrussell>
2019-10-03 04:32:57 +00:00
Christian Decker
d5f0c08a88
elements: Remove global is_elements variable in favor of chainparams
...
No need to keep duplicate globals.
2019-10-03 04:32:57 +00:00
Rusty Russell
f1b57063f7
bitcoin/tx: use fromwire_fail in pull_bitcoin_tx.
...
This is the correct way to mark failure: it also sets *max to 0.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-06-21 03:56:59 +00:00
Christian Decker
cc31efd0e8
wally: Migrate run-tx-encode to directly access the wally_tx
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2019-04-08 00:00:00 +00:00
Rusty Russell
8340d8c070
secret_eq: remove in favor of constant time variant.
...
To be safe, we should never memcmp secrets. We don't do this
currently outside tests, but we're about to.
The tests to prove this as constant time are the tricky bit.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-23 14:46:22 +02:00
Rusty Russell
5cf34d6618
Remove tal_len, use tal_count() or tal_bytelen().
...
tal_count() is used where there's a type, even if it's char or u8, and
tal_bytelen() is going to replace tal_len() for clarity: it's only needed
where a pointer is void.
We shim tal_bytelen() for now.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-07-30 11:31:17 +02:00
practicalswift
abf510740d
Force the use of the POSIX C locale for all commands and their subprocesses
2018-04-27 14:02:59 +02:00
practicalswift
b8846dad49
Readability: Use streq instead of strcmp
2018-03-16 01:17:40 +00:00
Rusty Russell
0237e0b28c
bitcoin: create new wrapper type bitcoin_txid, log backward endianness.
...
It's just a sha256_double, but importantly when we convert it to a
string (in type_to_string, which is used in logging) we use
bitcoin_txid_to_hex() so it's reversed as people expect.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-21 11:05:38 +00:00
Rusty Russell
a37c165cb9
common: move some files out of lightningd/
...
Basically all files shared by different daemons.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-29 17:54:14 +02:00
Rusty Russell
8522a5ea64
struct bitcoin_tx: remove explicit lengths, use tal_len()/tal_count()
...
They're always tal objects, so we can simply ask tal for the length,
simplifying the API.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-01-25 11:03:55 +10:30
Rusty Russell
809caa8588
bitcoin/pullpush.[ch]: expose bitcoin-style marshal/unmarshal.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-08-18 14:23:45 +09:30
Rusty Russell
9eabab78ab
utils: tal_hexstr() helper.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-05-03 11:28:49 +09:30
Rusty Russell
6b956ea22a
varint: new file.
...
Move varint handling from tx.c and generalize it.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-04-12 13:07:03 +09:30
Rusty Russell
ed70b13041
bitcoin: add first unit test.
...
Should grow from here.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-04-11 16:42:53 +09:30
