mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-07 14:29:33 +01:00
Code Issues Projects Releases Wiki Activity
11,447 Commits 34 Branches 196 Tags 136 MiB
ae71a87c40
Commit Graph

11447 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rusty Russell
6a7a046f60 state: add peer_unwatch_close_timeout() call. 
This tell us to disarm the INPUT_CLOSE_COMPLETE_TIMEOUT: either we hit
an error and are going to unilateral close, or we received their signature
successfully.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
144ab3bef4 state: make tx arguments const. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
ebf2bc57d8 state: add async anchor creation. 
Actually generating the anchor transaction in my implementation
requires interaction with bitcoind, which we want to be async.  So add
a callback and a new state to wait for it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
0db3c03ed1 state: fix BITCOIN_HTLC_TOTHEM_SPENT idata. 
We use both union fields idata->btc and idata->htlc, which is clearly
wrong.  Have peer_tx_revealed_r_value return the HTLC it's talking
about.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
2b3d5b4049 state: remove all traces of struct state_effect. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
63ea6bfd7a state: add callbacks for adding/removing watches. 
This lets us eliminate struct state_effect altogether (the next patch
removes the now-unused arguments).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
1a20e8094f state: return tx to be queued directly. 
Instead of effect->broadcast_tx.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
e984df486d state: return Pkt to be queued directly. 
Instead of effect->send_pkt.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
7383da5f87 state: remove update_theirsig effect. 
They get this from accept_pkt_update_accept() or accept_pkt_update_signature().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
63cb0667f6 state: use callbacks for htlc management. 
We only have one htlc in flight at a time, but sometimes it changes:
particularly when we are lowpriority and a highpriority request comes
in.  Handle this using a set of callbacks for htlc handling.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
c1dc7137ba names: generate names for command_status and state_peercond. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
f48adb097e state: use peer_unexpected_pkt() for an unexpected packet. 
Instead of effect->in_error.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
4d9041e62a state: fix case where we replied to an error with an error. 
Found by fixing bogus test in test_state_coverage.c

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
9013a7d872 state: set peer->state directly. 
Instead of new_state effect.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
4c9a9f8982 state: return status of current command. 
We temporarily move effect to the end of the arg list: we'll get rid
of it eventually.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
03268014b4 state: use PEER_BUSY when doing a command. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
14ede84d87 state: set peercond in peer directly. 
Instead of stop_packets or stop_commands effects.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
50a4b14a9a test/test_state_coverage.c: remove deferred packet handling. 
We no longer defer packets.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
3ab4ba1e6f state: add _THEYCOMPLETED states to reflect receiving PKT_OPEN_COMPLETE 
This is cleaner than deferring the packet receive and asking for it later.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
3c1b2ad1c1 state: don't defer CMD_SEND_HTLC_UPDATE 
Now we're covered by the opening command anyway, and the rule that you
can't have two commands at once.

There are two more defers:

1) In state STATE_WAIT_FOR_UPDATE_SIG_LOWPRIO/HIGHPRIO we are waiting for
   their signature because they started an HTLC, we defer any new HTLC
   creation, and
2) We defer PKT_OPEN_COMPLETE when we're waiting for anchor depth.

The first can be solved by a flag indicating whether we are accepting new
commands at all, the second by a pair of new states.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
fd370075f2 state: use STATE_INIT and separate inputs to decide on anchor. 
This is conceptually cleaner, especially since it means we're running
a command until we're set up (which prevents other commands, so no
special case needed).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
e5e58eeb00 state.c: fix assertion. 
They work on current state values, but they're wrong: use macros to
make it clearer.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
caa27f1d93 names.h/names.c: wrappers to get name for states/inputs. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
e6dfff3ba8 licensing: Make license explicit. 
Note that we're BSD-MIT but some of the ccan modules are different
licenses.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
7cf786f1f4 pull_bitcoin_tx: allocate outputs off tx itself. 
All the members of the transaction should be allocated off the
transaction, as they have the same lifetime.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
3a803eefbb bitcoin/tx: move bitcoin_tx_from_file() to test-cli, expose bitcoin_tx_from_hex() 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
04fd2c861f bitcoin/base58: p2sh address support. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
2516a187bc test-cli: use OpenChannel__AnchorOffer instead of book for open_channel_pkt() 
Clearer by being more explicit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
08367f8716 state: order headers correctly. 
make check-source will complain once we include state.c.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
bbd9d4aa01 state: inline input_is_pkt(). 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
15c5fca876 state: take struct peer instead of struct state_data. 
Just a name change for the test code, but this is what we'll be using
for the daemon.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
2c356fde55 state: remove unnecessary set_errpkt() helper. 
This was needed when idata->pkt wasn't a tal pointer, for testing,
but now it always is anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
85f4a7cf14 state: simplify effect. 
Make it a linked list of effects, rather than one big union.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
4d22b4e3eb pkt_open: use flag to indicate whether packet will offer anchor. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
93b5db89a8 signature: expose check_signed_hash() 
This is wanted for crypto communications to check signature.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
888389e625 ccan: update and add more. 
We need the following additional modules for the daemon:
	io, time, timer, pipecmd

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
906a5e4a32 Move pkt.c into test-cli. 
We use cryptopkt for normal cases.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
b312114719 pkt: don't convert endian on header. 
This is now only used for internal tests, so endian conversion is overkill.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
a38d0c985e Makefile: more fascist warnings. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:37 +10:30
Rusty Russell
4163935bbb ccan: import time module. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:09 +10:30
Rusty Russell
e97e8988f8 ccan: import isaac and dependencies. 
We could probably just use Openssl's RAND_pseudo_bytes, but this gives
a nice interface to get a number between 1 and N.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:09 +10:30
Rusty Russell
4795a4d46f Makefile: sanity check source and makefile 
This enforces the include order implemented by the previous patch, and
also make sure we haven't missed any headers.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:09 +10:30
Rusty Russell
9ebbe16b1e source cleanup: sort include lines into alpha order 
This makes merging easier in future.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
d733e82352 header cleanup: sort include lines into alpha order, after config.h 
This makes merging easier in future.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
4dafeba857 Makefile: depend on headers. 
A halfway house between the horror of dynamic generation and the fail of
making everything depend on every header.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
ffe20fb2ae bitcoin: add OP_CHECKLOCKTIMEVERIFY support (BIP65) 
No need to use noops now that BIP65 is active.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
aeedafc20f Switch to bitcoind by default. 
I haven't implemented getting transactions from alphad (it needs the values
for the inputs, too), so switch to bitcoind.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
e272d759a5 Force -walletbroadcast=1 for tests. 
Since lightningd wants walletbroadcast=0, override it on cmdline.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
2e873af86f locktime: complete the set of conversion functions. 
And add protobuf_convert helpers, too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
4b02c6f558 locktime: nice abstractions for absolute and relative locktimes. 
I got confused navigating these, especially since Alpha and Bitcoin
have diverged (BIP68 was proposed after Elements Alpha).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30