3 Commits

Author	SHA1	Message	Date
Rusty Russell	819078fe18	param: make command_fail/command_success WARN_UNUSED_RESULT. ... This causes a compiler warning if we don't do something with the result (hopefully return immediately!). We use was_pending() to ignore the result in the case where we complete a command in a callback (thus really do want to ignore the result). This actually fixes one bug: we didn't return after command_fail in json_getroute with a bad seed value. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2018-12-20 03:22:32 +00:00
Rusty Russell	93bf7c4839	param: make command sinks (fail/success) return a special type. ... These routines free the 'struct command': a common coding error is not to return immediately. To catch this, we make them return a non-NULL 'struct command_result *', and we're going to make the command handlers return the same (to encourage 'return command_fail(...)'-style usage). We also provide two sources for external use: 1. command_param_failed() when param() fails. 2. command_its_complicated() for some complex cases. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2018-12-20 03:22:32 +00:00
Rusty Russell	3f16c9a665	param: abstract 'struct command' so param doesn't need to access it. ... I want to use param functions in plugins, and they don't have struct command. I had to use a special arg to param() for check to flag it as allowing extra parameters, rather than adding a one-use accessor. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2018-12-10 00:00:50 +00:00