mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-23 23:06:44 +01:00
Code Issues Projects Releases Wiki Activity
13656 commits 33 branches 196 tags 157 MiB
Commit graph

2788 commits

Author SHA1 Message Date
Matt Morehouse
6b5df73cf4 fuzz: target for tx_remove_output 
Fuzz the decoding and encoding of tx_remove_output.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
f3db6642a1 fuzz: target for tx_remove_input 
Fuzz the decoding and encoding of tx_remove_input.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
7ddad8b7df fuzz: target for tx_init_rbf 
Fuzz the decoding and encoding of tx_init_rbf.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
1dda44c351 fuzz: target for tx_complete 
Fuzz the decoding and encoding of tx_complete.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
c0e8ccea49 fuzz: target for tx_add_output 
Fuzz the decoding and encoding of tx_add_output.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
dac211c73e fuzz: target for tx_add_input 
Fuzz the decoding and encoding of tx_add_input.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
82c719142e fuzz: target for tx_ack_rbf 
Fuzz the decoding and encoding of tx_ack_rbf.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
9b7ceb7307 fuzz: target for tx_abort 
Fuzz the decoding and encoding of tx_abort.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
4a09ef122e fuzz: target for stfu 
Fuzz the decoding and encoding of stfu.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
34ca0f6eac fuzz: target for splice_locked 
Fuzz the decoding and encoding of splice_locked.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
ae56dcf882 fuzz: target for splice_ack 
Fuzz the decoding and encoding of splice_ack.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
ea488f767b fuzz: target for splice 
Fuzz the decoding and encoding of splice.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
e473bfda16 fuzz: target for peer_storage 
Fuzz the decoding and encoding of peer_storage.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
451edb7c20 fuzz: target for open_channel2 
Fuzz the decoding and encoding of open_channel2.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
76ccdcd5d0 fuzz: target for onion_message 
Fuzz the decoding and encoding of onion_message.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
70694c23f1 fuzz: target for accept_channel2 
Fuzz the decoding and encoding of accept_channel2.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
a72128a0b6 fuzz: target for warning 
Fuzz the decoding and encoding of warning.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
d60077a8d9 fuzz: target for update_fulfill_htlc 
Fuzz the decoding and encoding of update_fulfill_htlc.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
41a2901ad4 fuzz: target for update_fee 
Fuzz the decoding and encoding of update_fee.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
08898333a4 fuzz: target for update_fail_malformed_htlc 
Fuzz the decoding and encoding of update_fail_malformed_htlc.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
298fe06c20 fuzz: target for update_fail_htlc 
Fuzz the decoding and encoding of update_fail_htlc.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
fb6d5cf587 fuzz: target for update_add_htlc 
Fuzz the decoding and encoding of update_add_htlc.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
1fff136d66 fuzz: target for shutdown 
Fuzz the decoding and encoding of shutdown.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
4aa165e7a2 fuzz: target for revoke_and_ack 
Fuzz the decoding and encoding of revoke_and_ack.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
1520fac809 fuzz: target for reply_short_channel_ids_end 
Fuzz the decoding and encoding of reply_short_channel_ids_end.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
4997d0df5b fuzz: target for reply_channel_range 
Fuzz the decoding and encoding of reply_channel_range.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
389ab0e46f fuzz: target for query_short_channel_ids 
Fuzz the decoding and encoding of query_short_channel_ids.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
10757bc49c fuzz: target for query_channel_range 
Fuzz the decoding and encoding of query_channel_range.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
c987b0e43c fuzz: target for pong 
Fuzz the decoding and encoding of pong.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
06f37a3c86 fuzz: target for ping 
Fuzz the decoding and encoding of ping.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
62ffb42908 fuzz: target for open_channel 
Fuzz the decoding and encoding of open_channel.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
07d593a24e fuzz: target for node_announcement 
Fuzz the decoding and encoding of node_announcement.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
b437835241 fuzz: target for init 
Fuzz the decoding and encoding of init.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
e41f263b72 fuzz: target for gossip_timestamp_filter 
Fuzz the decoding and encoding of gossip_timestamp_filter.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
9fababd668 fuzz: target for funding_signed 
Fuzz the decoding and encoding of funding_signed.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
247457f1f8 fuzz: target for funding_created 
Fuzz the decoding and encoding of funding_created.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
b1064e0309 fuzz: target for error 
Fuzz the decoding and encoding of error.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
1f974b8349 fuzz: target for commitment_signed 
Fuzz the decoding and encoding of commitment_signed.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
38a329f9e6 fuzz: target for closing_signed 
Fuzz the decoding and encoding of closing_signed.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
f409f3374c fuzz: target for channel_update 
Fuzz the decoding and encoding of channel_update.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
b7b046ce83 fuzz: target for channel_reestablish 
Fuzz the decoding and encoding of channel_reestablish.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
7686909c65 fuzz: target for channel_ready 
Fuzz the decoding and encoding of channel_ready.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
b56177c625 fuzz: target for channel_announcement 
Fuzz the decoding and encoding of channel_announcement.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
1b8137649a fuzz: target for announcement_signatures 
Fuzz the decoding and encoding of announcement_signatures.
 2023-09-18 13:58:45 +09:30
Matt Morehouse
ef28e54d65 fuzz: target for accept_channel 
Fuzz the decoding and encoding of accept_channel.

We create a wire.h header to share code with future targets.
 2023-09-18 13:58:45 +09:30
Tony Giorgio
a5367773d5 wallet: Exclude uneconomical UTXOs from fundchannel 
If a node has an onchain balance with at least one uneconomical UTXO, the fundchannel RPC call will lock up the node and will eventually crash it with OOM issues if the economical UTXO(s) do not add up to the fundchannel amount. This is because the while loop never exits because it keeps pulling in the same uneconomical UTXOs forever.

Changelog-Fixed: wallet: fundchannel no longer loops forever if the wallet contains insufficient funds, but an uneconomical UTXO.
 2023-09-13 14:34:59 +09:30
Rusty Russell
47f4e11c87 tests: test for fundchannel fail with tiny utxo 
Tony Giorgio <tonygiorgio@protonmail.com> says:

Reproduce:

1.  Add 1 600 sat UTXO to a fresh node

2.  Verify the fundchannel command fails with a low fee rate:

```
./lightning-cli fundchannel 0366abc8eb4da61e31a8d2c4520d31cabdf58cc5250f855657397f3dd62493938a 100000 1000
{
   "code": 301,
   "message": "Could not afford 100000sat using all 1 available UTXOs: 99522sat short"
}
```

3.  Now do the command again, but with a higher fee rate, making the 600 sat UTXO uneconomical:

```
./lightning-cli fundchannel 0366abc8eb4da61e31a8d2c4520d31cabdf58cc5250f855657397f3dd62493938a 100000 10000
```

4. Observe the RPC call and the logs. The RPC call will never return, and the logs will stop after this:

```
2023-04-16T10:58:45.839Z DEBUG   plugin-spenderp: mfc 34: multiconnect done.
2023-04-16T10:58:45.839Z DEBUG   plugin-spenderp: mfc 34: 'parsefeerate' done
2023-04-16T10:58:45.839Z DEBUG   plugin-spenderp: mfc 34: fundpsbt.
```

5. Keep CLN running long enough and you'll eventually run OOM.
 2023-09-13 14:34:59 +09:30
Rusty Russell
785fe973a6 runes: ensure that uniqueid is a valid number. 
It always is for runes we create, but in theory you can take our secret key
and make our own runes with your own tools.

(We correctly refuse runes without uniqueids if they're *not* ours
anyway: uniqueid is only used for our own runes).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2023-09-12 15:19:02 +09:30
Rusty Russell
ecb09778db lightningd: refuse to create rune with empty fields. 
These look like uniqueids, and so can confuse us (I discovered this by
making a typo in a test!)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2023-09-12 15:19:02 +09:30
Rusty Russell
bb38f83b88 checkrune: make nodeid and method optional. 
nodeid is only useful when we know the peer we're talking to (e.g. commando).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
No-schema-diff-check: We're simply making optional, not deprecating!
 2023-09-12 15:19:02 +09:30