mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-20 02:27:51 +01:00
Code Issues Projects Releases Wiki Activity
2,098 Commits 30 Branches 190 Tags 193 MiB
66a0c55322
Commit Graph

149 Commits

Author SHA1 Message Date
Rusty Russell
15f7ec436c Fix "make check-source" 
Obviously, haven't run it in a while.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-04-11 16:28:43 +09:30
Rusty Russell
e669baec1c bitcoin/signature: fix compilation with #define DEBUG 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-04-11 16:28:23 +09:30
Rusty Russell
b6943b9198 protocol: remove support for uncompressed pubkeys. 
There's no good reason to support them, and this way every key is 33 bytes.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-03-30 16:54:16 +10:30
Rusty Russell
c1d1b360bf daemon: add memcheck() in various places where we expect things to be initialized. 
This just causes valgrind to warn sooner.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-03-08 10:31:15 +10:30
Rusty Russell
6750794667 Use #if instead of #ifdef (we already use -Wundef). 
This avoids embarassing typos in future.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-27 15:00:50 +10:30
Rusty Russell
9aa0eac814 bitcoin: hand in a secp256k1_context to all routines. 
We don't want to re-create them internally, ever.

The test-cli tools are patched to generate them all the time, but
they're not performance critical.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
3374ddd2a6 bitcoin: use a length arg to bitcoin_tx_from_hex 
Our json parser doesn't use nul-terminated strings.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
cf547d491b bitcoin: add len arg to pubkey conversion function. 
Our json parser doesn't give nul-terminated strings.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:47 +10:30
Rusty Russell
7cf786f1f4 pull_bitcoin_tx: allocate outputs off tx itself. 
All the members of the transaction should be allocated off the
transaction, as they have the same lifetime.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
3a803eefbb bitcoin/tx: move bitcoin_tx_from_file() to test-cli, expose bitcoin_tx_from_hex() 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
04fd2c861f bitcoin/base58: p2sh address support. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:46 +10:30
Rusty Russell
93b5db89a8 signature: expose check_signed_hash() 
This is wanted for crypto communications to check signature.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:41:45 +10:30
Rusty Russell
9ebbe16b1e source cleanup: sort include lines into alpha order 
This makes merging easier in future.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
d733e82352 header cleanup: sort include lines into alpha order, after config.h 
This makes merging easier in future.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
2e873af86f locktime: complete the set of conversion functions. 
And add protobuf_convert helpers, too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
4b02c6f558 locktime: nice abstractions for absolute and relative locktimes. 
I got confused navigating these, especially since Alpha and Bitcoin
have diverged (BIP68 was proposed after Elements Alpha).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
4c42930940 bitcoin/tx, protobuf_convert: support BIP68 as implemented. 
The format for both the nSequence field and the stack arg for
OP_CHECKSEQUENCEVERIFY is either:

  Time-relative:	[Bit 22 = 1] 00000 <time-shifted-by-9>
  Block-relative:	[Bit 22 = 0] 00000 <number of blocks>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
4e23f9916d script: encode numbers minimally. 
This happens for CSV, for example (3-byte encoding), and bitcoind treats
too-long encodings as non-standard.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2016-01-22 06:38:08 +10:30
Rusty Russell
6b2d844f2a bitcoin: use ccan/mem instead of rolling own check_mem function. 
Reported-by: John Newbery
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-10-26 21:06:23 +10:30
Rusty Russell
32fe988fe8 bitcoin: signature fixes. 
The libsecp change broke signature checking.  Disable it for now,
with a big FIXME.  The next version should have a method for S value
checking, and also compact serialization.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-10-12 10:45:02 +10:30
Rusty Russell
242fa1b2dd pubkey: pubkey_eq helper. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-09-30 16:38:58 +09:30
Rusty Russell
e7856e6e69 Update libsecp to git@github.com:bitcoin/secp256k1.git 52fd03f 
We want the ecdh stuff for onion routing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-09-30 16:37:21 +09:30
Rusty Russell
454a3867e5 BIP68 support (nSequence enforcement) 
The latest version of the BIP doesn't use inversion, but does use
bitshifts.

It also uncovered a bug in the test scripts: the block timestamps
creep forward when we generate large numbers of blocks (UpdateTime
insists it be > GetMedianTimePast() so it's valid).  We need to take
this into account when waiting for the median to move (reduced it from
60 to 30 seconds, since that adds about 14 seconds).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-09-30 10:54:11 +09:30
Rusty Russell
58a62e782d bitcoin/script: don't pass value for HTLC script. 
We don't need it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-09-24 14:56:01 +09:30
Rusty Russell
08ae4a687d script: HTLC support. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-08-07 12:45:30 +09:30
Rusty Russell
cf3433a0ad script: add OP_CHECKLOCKTIMEVERIFY. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-08-07 12:45:30 +09:30
Rusty Russell
0170ad4abd script: add add_push_le32 helper. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-08-07 12:45:30 +09:30
Rusty Russell
c4d5a85b4e protocol: remove tx_version field. 
It's trivial to add later as an optional field.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-29 12:00:49 +09:30
Rusty Russell
ee3af28980 test-cli/txid-of: simple helper to get txid. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-24 16:00:10 +09:30
Rusty Russell
6a5ba591ee signature: match alpha hashing bug for multiple inputs. 
https://github.com/ElementsProject/elements/issues/37

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-24 16:00:10 +09:30
Rusty Russell
aa79887d79 script: use the normalized delay script form for commit output. 
As documented in the paper; it's also two bytes shorter, and allows
us to use the exact same script for three cases.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-24 16:00:10 +09:30
Rusty Russell
d053181b0b script: add standard routines for secret-or-timedelay outputs. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-24 16:00:10 +09:30
Rusty Russell
465c2b04e8 signature: fix -DDEBUG case, add hash printing. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-24 16:00:10 +09:30
Rusty Russell
8f64eb90af Switch over to CCAN's ripemd160. 
Avoids handing naked u8 arrays around, too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-09 15:43:36 +09:30
Rusty Russell
66b1df4036 tx: locktime should be 0. 
It doesn't matter until we start setting sequence numbers properly,
so hasn't been noticed until now.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-03 10:44:44 +09:30
Rusty Russell
ae31431168 tx: centralize transaction writing, append amounts for alpha. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:55:11 +09:30
Rusty Russell
62a002c860 script: make DER for signature encoding optional. 
Alpha does the sane thing, places signatures raw.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:27:52 +09:30
Rusty Russell
faae91f3fc Schnorr signature support. 
This variation is used by alpha.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:27:52 +09:30
Rusty Russell
1d82bf51fc signature: fix invalid S check. 
The even-S check was based on https://github.com/sipa/bitcoin/commit/a81cd9680
which was replaced by a low-S check in commit e0e14e43d9586409e42919f6cb955540134cda2a

Abstract out and fix the check.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:27:52 +09:30
Rusty Russell
d20ddb5a90 Use libsecp256k1 instead of openssl for crypto. 
We still use openssl for bignums (base58) and for ripemd.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:27:52 +09:30
Rusty Russell
fbe63124f6 Move DER encoding into bitcoin/signature.c 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:27:52 +09:30
Rusty Russell
20624c049f tx: prepare for Elements Alpha. 
They sign, hash, and serialize differently.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-07-01 16:27:45 +09:30
Rusty Russell
61737a79d2 Fix typo. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-25 13:48:05 +09:30
Rusty Russell
602117e8bb Add valgrind memcheck helpers. 
Otherwise valgrind tells you when you test a hash; you want to
know if you hash uninitialized memory long before that.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-24 16:15:34 +09:30
Rusty Russell
143e7e032c Optimize revocable output a little. 
Both paths do CHECKSIG, do that outside.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-23 16:05:09 +09:30
Rusty Russell
9f12b72476 Don't include mutual redemption in recovable commit tx output. 
It's not clear it's needed, and without it there's a good reason to
delay dumping to the blockchain if a node becomes unreachable (since
you'll get your money faster if it comes back online).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-12 12:41:30 +09:30
Rusty Russell
ef9463f6b1 Sort include lines (ignoring hacky cli test utils). 
Put ccan first, openssl next, then standard headers, then locals.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-12 12:41:28 +09:30
Rusty Russell
442f321585 Move protobuf<->bitcoin converters out of bitcoin/ 
They're lightning-specific.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-12 12:35:42 +09:30
Rusty Russell
612d713470 Move bitcoin stuff into bitcoin subdir. 
It's not very interesting if you're looking for LN code.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2015-06-12 12:35:42 +09:30