Rusty Russell
2de467274e
common/amount: make fmt_amount_sat / fmt_amount_msat etc take copy.
...
We pass by copy everywhere else, let's do it here too.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-01-09 12:45:31 +01:00
Rusty Russell
3b7d0e7a62
common/json: make json_scan return an error string.
...
This makes for more useful errors. It prints where it was up to in
the guide, but doesn't print the entire JSON it's scanning.
Suggested-by: Christian Decker
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-01-07 19:32:47 +01:00
Rusty Russell
b61da8c5a9
plugins: use json_scan.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-01-07 19:32:47 +01:00
Rusty Russell
2b6cdfeb5a
json_to_psbt: fix API to match other allocating json_to functions.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-01-07 19:32:47 +01:00
niftynei
0726d2912e
df-mfc: remove guard-rails for failures
...
This will cause blow ups for v2 multifundchannel attempts with failures,
but allows us to return the expected errors for single-shot
fundchannel attempts.
Error handling is coming, i promise
2021-01-06 14:50:02 +01:00
niftynei
6e3c517611
mfc-df: if there's an error with a openchannel_signed, fail
...
Ideally we'd 'cure' the error and re-attempt, except that if this was a
bitcoin-backend 'failure to broadcast' then it really needs user
intervention to figure out what's wrong -- it's possible that the
peer successfully broadcast the transaction
2021-01-06 14:50:02 +01:00
niftynei
6077eca660
df: pass back 'close_to' for completed/commitment secured channels
...
When commitments are secured, also return the 'close_to' script if we've
got a local_upfront_shutdown_script set.
2020-11-23 12:41:05 -06:00
niftynei
c6b45e052b
mfc-df: after openchannel_signed is finished, we call finished
...
We done!?
2020-11-23 12:41:05 -06:00
niftynei
3e19b6c8f5
mfc-df: after psbt signed, send to openchannel_signed if v2s
...
If there's an v2 destinations, they'll broadcast the tx for us
2020-11-23 12:41:05 -06:00
niftynei
a34425abd1
mfc-df: after sigs are collected, go sign the psbt
2020-11-23 12:41:05 -06:00
niftynei
d7c06b5b0e
mfc-df: once we've gotten the PSBT finalized, we wait for peer sigs
...
We need our peer's signatures to arrive before we sign/broadcast the
funding transaction (but only if there's v2 peers present)
2020-11-23 12:41:05 -06:00
niftynei
c90a19f739
mfc-df: only add outputs for v1 outs; go to openchannel_update if v2s
...
We only have output scripts for v1 protocols after the
fundchannel_start/openchannel_init round. We need to add them before
we get into the openchannel_update rounds, however, so we do that here.
2020-11-23 12:41:05 -06:00
niftynei
3d2c0951d5
mfc-df: rework how openchannel_update works, callbacks
2020-11-23 12:41:05 -06:00
niftynei
381658dee6
mfc-df: merge openchannel_init/fundchannel_start results
...
These happen simultaneously, and should resolve to the same place when
they're finished.
2020-11-23 12:41:05 -06:00
niftynei
95de8b1174
mfc-df: have both paths use redo_multifundchannel
...
Still need handling of failure for v2 opens (no rpc exists?!)
2020-11-23 12:41:05 -06:00
niftynei
a31b078721
mfc: consolidate to a single FAILED state
2020-11-23 12:41:05 -06:00
niftynei
e0c4865eea
mfc: add a 'fail_destination' helper
...
Caches state at which we failed + sets error
2020-11-23 12:41:05 -06:00
niftynei
5b6b012af9
mfc: add happy path-way for v2 in multifundchannel
...
Tested and works with both sides funding! Yay.
Doesn't do any amount of reasonable cleanup or handling of errors.
2020-11-23 12:41:05 -06:00
