Rusty Russell
4ee9d1d2f2
gossmap: include cltv_expiry_delta in gossmap_chan_get_update_details for completeness.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2024-10-15 09:58:04 +10:30
Rusty Russell
5052f0763f
gossmap: keep capacity for locally-generated channels as well.
...
It was weird not to have a capacity associated with localmods channels, and
fixing it has some very nice side effects.
Now the gossmap_chan_get_capacity() call never fails (we prevented reading
of channels from gossmap in the partially-written case already), so we
make it return the capacity. We do this in msat, because that's what
all the callers want.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2024-10-04 11:27:53 +09:30
Rusty Russell
b29b96aae8
common: hoist scidd->pubkey conversion function into gossmap.
...
We will want to use it in the pay plugin too.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2024-07-18 10:53:55 +09:30
Rusty Russell
9450d46db1
bitcoin/short_channel_id: pass by copy everywhere.
...
It's a u64, we should pass by copy. This is a big sweeping change,
but mainly mechanical (change one, compile, fix breakage, repeat).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2024-03-20 13:51:48 +10:30
Rusty Russell
37ccca5d69
common/gossmap: remove now-unused private flag.
...
The only way you'll see private channel_updates is if you put them
there yourself with localmods.
I also renamed the confusing gossmap_chan_capacity to gossmap_chan_has_capacity.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2024-02-04 09:24:44 +10:30
Rusty Russell
674684369f
common: prepare unit tests for lack of private channels.
...
Created a new canned gossmap without private channels, updated tests.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2023-12-14 09:16:56 +10:30
Michael Schmoock
f67ab2a86e
test: run-gossmap update test store instructions
...
Changelog-None
2022-07-12 13:59:46 -05:00
Christian Decker
9ff9d3d4e3
tests: Fix the canned gossmap
...
The gossip_store version was bumbed to 10 in PR #5239 and #5375 has
apparently not been rebased on top of that when it was merged, causing
the `run-gossmap_canned` test to fail when parsing the v9 gossip
store.
Changelog-None
2022-07-11 14:24:10 -05:00
Rusty Russell
ae71a87c40
ccan: update to latest htable fixes, and update gossmap to meet new assertions.
...
Updating ccan to stricter htable revealed we were trying to put
(void *)1 in the htable, which is forbidden:
```
topology: ccan/ccan/htable/htable.c:382: htable_add_: Assertion `entry_is_valid((uintptr_t)p)' failed.
topology: FATAL SIGNAL 6 (version 1358d7f)
0x55f30c689c34 send_backtrace
common/daemon.c:33
0x55f30c689ce0 crashdump
common/daemon.c:46
0x7f5d150fe51f ???
./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f5d15152828 __pthread_kill_implementation
./nptl/pthread_kill.c:44
0x7f5d15152828 __pthread_kill_internal
./nptl/pthread_kill.c:80
0x7f5d15152828 __GI___pthread_kill
./nptl/pthread_kill.c:91
0x7f5d150fe475 __GI_raise
../sysdeps/posix/raise.c:26
0x7f5d150e47b6 __GI_abort
./stdlib/abort.c:79
0x7f5d150e46da __assert_fail_base
./assert/assert.c:92
0x7f5d150f5e25 __GI___assert_fail
./assert/assert.c:101
0x55f30c6adbe4 htable_add_
ccan/ccan/htable/htable.c:382
0x55f30c65f303 chanidx_htable_add
common/gossmap.c:35
0x55f30c6605ed new_channel
common/gossmap.c:337
0x55f30c6609cf add_channel
common/gossmap.c:425
0x55f30c661101 map_catchup
common/gossmap.c:607
0x55f30c66221e gossmap_refresh
common/gossmap.c:927
0x55f30c66e3e9 get_gossmap
plugins/topology.c:27
0x55f30c66f939 listpeers_done
plugins/topology.c:369
0x55f30c671f46 handle_rpc_reply
plugins/libplugin.c:558
0x55f30c672a19 rpc_read_response_one
plugins/libplugin.c:726
0x55f30c672b4f rpc_conn_read_response
plugins/libplugin.c:746
0x55f30c6ae35e next_plan
ccan/ccan/io/io.c:59
0x55f30c6aef93 do_plan
ccan/ccan/io/io.c:407
0x55f30c6aefd5 io_ready
ccan/ccan/io/io.c:417
0x55f30c6b1371 io_loop
ccan/ccan/io/poll.c:453
0x55f30c67587c plugin_main
plugins/libplugin.c:1559
0x55f30c6708eb main
plugins/topology.c:701
0x7f5d150e5fcf __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
0x7f5d150e607c __libc_start_main_impl
../csu/libc-start.c:409
0x55f30c65d894 ???
???:0
0xffffffffffffffff ???
???:0
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-07-10 20:48:53 -05:00
