mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-09 07:10:16 +01:00
Code Issues Projects Releases Wiki Activity
4,253 Commits 34 Branches 196 Tags 136 MiB
136f10e4a3
Commit Graph

4253 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rusty Russell
0e6c0dbba2 bitcoin: expose feerate_floor. 
Onchaind will want it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-21 13:43:32 +02:00
Christian Decker
4a5cff8490 gossip: Try to detect broken ISP resolvers and discard broken replies 
This is a best effort attempt to skip connection attempts if we detect a broken
ISP resolver. A broken ISP resolver is a resolver that will replace NXDOMAIN
replies with a dummy response. This is best effort in that it'll only detect a
single fixed dummy reply, it'll check only on startup, and will not detect if we
switched networks. It should be good enough for most cases, and in the worst
case it will result in a connection attempt that does not complete.

Signed-off-by: Christian Decker <decker.christian@gmail.com>
Reported-by: Glenn Willen <@gwillen>
 2018-06-21 11:21:16 +02:00
Christian Decker
e556bf4f36 pytest: Disable DNS lookups during test runs 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-21 11:21:16 +02:00
Christian Decker
91c2416657 gossip: Do not use DNS if we were told not to 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-21 11:21:16 +02:00
Christian Decker
ceef61dbbd gossip: Pass use_dns option down to gossipd 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-21 11:21:16 +02:00
Christian Decker
1bfa02d877 opts: Add option to disable DNS lookups 
Mainly used to disable `gossipd` reaching out to the DNS seeds during testing.

Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-21 11:21:16 +02:00
William Casarin
d7aa0528b8 gossipd: fix compile error, uninitialized variable 
Seems to be a problem with gcc 6.4+?

Fixes #1527

Signed-off-by: William Casarin <jb55@jb55.com>
 2018-06-20 21:25:03 +00:00
arowser
85e02127a9 align generate wire template 2018-06-20 06:56:42 +00:00
Christian Decker
654fa9d680
doc: Fixed typo in the release notes 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-18 12:45:00 +02:00
Rusty Russell
7f508cca5f wallet: clarify error 302. 
"Dust limit unmet" seems undescriptive to me.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:33:25 +02:00
Mark Beckwith
f4eda74789 adding manpages 2018-06-18 12:33:25 +02:00
Mark Beckwith
8f0ef1636f Added wallet related error codes 
New codes: FUND_MAX_EXCEEDED, FUND_CANNOT_AFFORD, FUND_DUST_LIMIT_UNMET.

The error message "Cannot afford fee" was not exactly correct because
it would also occur if the amount requested could not be afforded.  So
I changed it to the more generic "Cannot afford transaction".

Other things:

* Fixed off-by-one satoshi in fundchannel manpage.
* Changed 'arror' to 'error' because we are not pirates.
 2018-06-18 12:33:25 +02:00
Christian Decker
2d95ed738e pay: Use locktime_max as maximum cumulative CLTV delta 
Proposed by @rustyrussell.
Fixes #1586

Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-18 12:31:28 +02:00
Rusty Russell
e549bc6ecf lightningd: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
ce4eef6943 wire/*: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
18a6cbd11f bitcoin/*: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
80182ce275 openingd: fix up BOLT references. 
Some of these are from the master branch, and were not when the query-gossip
extensions were made, so I've had to mark some with FIXME.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
3460b42513 onchaind: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
0221e81234 closingd: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
b40b6240ce channeld: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
833e8387aa gossipd: fix up BOLT references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
014428f81b common: fix up BOLT 7 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
0cf9f85fb7 common: fix up BOLT 1 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
90c583f464 common: fix up BOLT 2 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
8553edb7e2 common: fix up BOLT 4 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
dba756ef38 common: fix up BOLT 3 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
0dc406c07a common/bolt11.c: fix up BOLT 11 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
f5d637059d common/cryptomsg.c: fix up bolt 8 references. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
8c15e619a3 Makefile: update BOLTVERSION 
This refers to the commit with query extensions.  Those should be merged
soon.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:31:09 +02:00
Rusty Russell
a5aaf82ed2 release-notes: 
Feedback from @wythe and @cdecker
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-18 12:30:31 +02:00
Rusty Russell
2180ff0a72 Release notes for 0.6 "I Accidentally The Smart Contract" 
Written by Christian Decker wth feedback from Shannon Appelcline.
Special thanks to Fabrice Drouin of ACINQ fame for choosing the release
name!
 2018-06-18 12:30:31 +02:00
Christian Decker
71ec8193b2
gossip: Avoid integer count overflow in gossip_store 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-18 12:04:25 +02:00
Corné Plooy
94ef0a7fbf Add 'make ncc' target, for source code analysis. 2018-06-15 16:49:35 +02:00
Rusty Russell
f5ebf8e231 gossipd: send correct channel_update in response to query_short_channel_ids 
Cut & paste means we sometimes sent NULL:

```
2018-06-15T00:13:51.908Z lightningd(23653): lightning_closingd-03864ef025fde8fb587d989186ce6a4a186895ee44a926bfc370e2c366597a3f8f chan #436: Gossipd gave us bad send_gossip message 0bc80000
```

Fixes: #1581
Reported-by: @Xian001
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 15:39:30 +02:00
Rusty Russell
60b3f0e376 gossipd: remove oververbose logging when we uncompress short_channel_id array 
Reported-by: Xian001 (#1581)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 15:39:30 +02:00
Rusty Russell
4990b6bbcc channeld: don't crash if remote asks for unnecessary retransmit. 
We assume they haven't acknowledged it, but they might have (seems
like a bug though).  We could hang up on them, but we'll happily
continue.

lightning_channeld: channeld/channel.c:1702: resend_commitment: Assertion `peer->revocations_received == peer->next_index[REMOTE] - 2' failed.
lightning_channeld: Fatal signal 6
0x559919c35dcd crashdump
        common/daemon.c:37
0x7f76d5be27ef ???
        ???:0
0x7f76d5be277f ???
        ???:0
0x7f76d5be4379 ???
        ???:0
0x7f76d5bdab46 ???
        ???:0
0x7f76d5bdabf1 ???
        ???:0
0x559919c29337 resend_commitment
        channeld/channel.c:1702
0x559919c297cf peer_reconnect
        channeld/channel.c:1853
0x559919c2b3d5 init_channel
        channeld/channel.c:2518
0x559919c2b6f8 main
        channeld/channel.c:2580
0x7f76d5bcd3f0 ???
        ???:0
0x559919c244d9 ???
        ???:0
0xffffffffffffffff ???
        ???:0

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Rusty Russell
9d721ecb99 gossipd: add assertions to try to catch mysterious crash. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Rusty Russell
a80241ec7a bitcoind: fix spurious memleak reports. 
Turn req_running into a pointer to the current bcli structure, which means
the leak detection can find it.

Also suppress leaks in the case where we're only attached to a timer

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Rusty Russell
5c19c55841 gossipd: fix take leak when peer is dying. 
In this case, local and remote are *both* NULL; so if someone tries to
send a packet with take(), we need to free it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Rusty Russell
a7e6cdb418 gossipd: peer->local->peer_out queue should have lifetime of peer->local. 
The current code attaches it to peer, which is a slight leak.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Rusty Russell
e098578731 gossipd: fix leak when we fail to dup fds. 
In this case, peer would stay around, but conn would be freed.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Rusty Russell
f6ff89e596 gossipd: fix use-after-free when we fail to make connection. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-15 11:53:47 +02:00
Christian Decker
4279e5cdbd gossip: Fix "already reaching" issue 
I think this is what is causing #1536: getting disconnected causes gossipd to
attempt to reach the peer again, unconditionally setting the flag to tell the
master. At the same time the master also issues a reaching command (which is
allowed since it is its first), but then it clashes on the already set
flag. Setting this flag only when the master actually needs to be told should
fix this.

Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-06-15 01:06:42 +00:00
Jan Sarenik
40ea74ba99 configure: Check for version of pytest 
Addresses #486 and takes into account @rustyrussell 's
comment about PYTEST defined in the environment which
always overrides without checking the version.
 2018-06-15 01:55:44 +02:00
Benoit Verret
f8da37fff0 Increase cltv_final 
During a meeting earlier this week we agreed with Eclair to temporarily
increase the final CLTV delta in our invoices to establish
compatibility with the already deployed Eclair wallets. They in turn
agreed to remove the enforcement of higher final CLTV deltas, or bump
it locally should it not match their expectations as allowed by
BOLT 11. This has since been implemented in ACINQ/eclair#627.
 2018-06-14 15:03:56 +02:00
Rusty Russell
6a73c7eeb1 configure: fix defaults in help. 
Both "[ 1 ]" and "[ 0 ]" both evaluate true in shell; we really want
an explicit '1' test.

Before:
$ ./configure --help
...
  --enable/disable-compat (default disable)

After:
$ ./configure --help
...
  --enable/disable-compat (default enable)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-14 14:38:24 +02:00
Rusty Russell
361ed8675a Makefile: we should use COMPAT instead of NO_COMPAT. 
That's what configure defines.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-14 14:38:24 +02:00
Rusty Russell
0fff5038ff Makefile: we don't need to define DEVELOPER explicitly. 
config.h does this.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-14 14:38:24 +02:00
Jan Sarenik
e5809cf268 external/libwally-core: Update to master after release_0.6.1 
The extra patch after release_0.6.1 fixes another set of
FORTIFY warnings.

See https://github.com/ElementsProject/libwally-core/pull/36
 2018-06-14 14:26:25 +02:00
Rusty Russell
46aaf08047 configure: add hack to rename ccan's sha256 routines to avoid libwally clash 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-14 14:26:25 +02:00