mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-12-28 01:24:42 +01:00
Code Issues Projects Releases Wiki Activity
11,629 Commits 32 Branches 196 Tags 136 MiB
008a59b004
Commit Graph

59 Commits

Author SHA1 Message Date
Rusty Russell
f65d3bb1fc ccan: upgrade to get ccan/runes. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2022-07-17 08:51:02 +09:30
Rusty Russell
ae71a87c40 ccan: update to latest htable fixes, and update gossmap to meet new assertions. 
Updating ccan to stricter htable revealed we were trying to put
(void *)1 in the htable, which is forbidden:

```
topology: ccan/ccan/htable/htable.c:382: htable_add_: Assertion `entry_is_valid((uintptr_t)p)' failed.
topology: FATAL SIGNAL 6 (version 1358d7f)
0x55f30c689c34 send_backtrace
	common/daemon.c:33
0x55f30c689ce0 crashdump
	common/daemon.c:46
0x7f5d150fe51f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f5d15152828 __pthread_kill_implementation
	./nptl/pthread_kill.c:44
0x7f5d15152828 __pthread_kill_internal
	./nptl/pthread_kill.c:80
0x7f5d15152828 __GI___pthread_kill
	./nptl/pthread_kill.c:91
0x7f5d150fe475 __GI_raise
	../sysdeps/posix/raise.c:26
0x7f5d150e47b6 __GI_abort
	./stdlib/abort.c:79
0x7f5d150e46da __assert_fail_base
	./assert/assert.c:92
0x7f5d150f5e25 __GI___assert_fail
	./assert/assert.c:101
0x55f30c6adbe4 htable_add_
	ccan/ccan/htable/htable.c:382
0x55f30c65f303 chanidx_htable_add
	common/gossmap.c:35
0x55f30c6605ed new_channel
	common/gossmap.c:337
0x55f30c6609cf add_channel
	common/gossmap.c:425
0x55f30c661101 map_catchup
	common/gossmap.c:607
0x55f30c66221e gossmap_refresh
	common/gossmap.c:927
0x55f30c66e3e9 get_gossmap
	plugins/topology.c:27
0x55f30c66f939 listpeers_done
	plugins/topology.c:369
0x55f30c671f46 handle_rpc_reply
	plugins/libplugin.c:558
0x55f30c672a19 rpc_read_response_one
	plugins/libplugin.c:726
0x55f30c672b4f rpc_conn_read_response
	plugins/libplugin.c:746
0x55f30c6ae35e next_plan
	ccan/ccan/io/io.c:59
0x55f30c6aef93 do_plan
	ccan/ccan/io/io.c:407
0x55f30c6aefd5 io_ready
	ccan/ccan/io/io.c:417
0x55f30c6b1371 io_loop
	ccan/ccan/io/poll.c:453
0x55f30c67587c plugin_main
	plugins/libplugin.c:1559
0x55f30c6708eb main
	plugins/topology.c:701
0x7f5d150e5fcf __libc_start_call_main
	../sysdeps/nptl/libc_start_call_main.h:58
0x7f5d150e607c __libc_start_main_impl
	../csu/libc-start.c:409
0x55f30c65d894 ???
	???:0
0xffffffffffffffff ???
	???:0
```

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2022-07-10 20:48:53 -05:00
Rusty Russell
ea73e49f2c ccan: update to get io_sock_shutdown 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2022-01-20 15:24:06 +10:30
Rusty Russell
8759641b06 ccan: update to get new helpers in ccan/tal 
tal_dup_talarr() is simply stolen from common/utils, but tal_dup_or_null is new.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-12-30 14:36:55 +10:30
Rusty Russell
064e239ae1 ccan: update, add graphql module. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-12-15 06:53:23 +10:30
Rusty Russell
8b348a5485 ccan: import udpated version (with better tal_dump() format). 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-11-27 10:38:13 +10:30
ZmnSCPxj jxPCSnmZ
5a84abb09e ccan: update to include closefrom 
Signed-off-by: ZmnSCPxj jxPCSnmZ <ZmnSCPxj@protonmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-10-22 13:17:37 +02:00
Rusty Russell
b34953dd5e ccan: update to get version where tal_dump goes to stderr. 
This is useful for plugins which can't send junk to stdout.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-09-08 19:11:47 +02:00
Rusty Russell
38fad0f3e4 ccan: update to get RETURNS_NONNULL macro. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-06-16 10:29:17 +09:30
Rusty Russell
d06e84cceb ccan: import latest 
Which includes not asserting in timer.c should time go backwards.

Fixes: #4401
Changelog-Fixed: lightningd: don't assert if time goes backwards temporarily.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-03-23 14:24:38 -05:00
Rusty Russell
ae1a130ab5 ccan: update ccan/utf-8 to reject NULs embedded in strings. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2020-12-02 10:38:04 +10:30
Rusty Russell
d970addd4b ccan: update to latest version, get json_out_finished update. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2020-10-23 13:53:16 +10:30
Rusty Russell
7ca00ca7d7 ccan: update so we can compile with -O2 on Ubuntu. 
Otherwise we get a configurator failure:

    In file included from /usr/include/string.h:495,
                     from configuratortest.c:2:
    In function ‘strncpy’,
        inlined from ‘main’ at configuratortest.c:6:2:
    /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 8 equals destination size [-Wstringop-truncation]
      106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2020-07-17 13:54:06 +02:00
Rusty Russell
9d9480f17e ccan: update to latest version which allows destructors to self-delete. 
Also, a fix for compiling with NDEBUG.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2020-02-17 19:55:13 +10:30
Rusty Russell
be8e261da6 ccan: update to include opt_unregister fix. 
This was caught by valgrind on Travis, and really confused me.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2020-02-11 16:37:21 +10:30
Rusty Russell
6209ae1abf ccan: update to get configurator with --wrapper option 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2020-02-06 13:37:54 +10:30
Rusty Russell
1f9de04ae4 ccan: import updated version to get uintmap_before(). 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-10-10 21:48:52 -05:00
Rusty Russell
25ddb80823 ccan: update to fix shutdown slowness after plugin load. 
Dynamic plugins were keeping fds open; they should not have these
at all anyway, but worse, they interfere with operation because
we don't notice they're closed.

The symptom was that shutdown of the test_plugin_slowinit and
test_plugin_command was 30 seconds (10 seconds grace to kill each daemon).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-08-15 02:22:01 +00:00
Rusty Russell
79345cc0b9 CCAN: update to suppress path_readlink warning. 
Reported-by: Chirimen-Jako
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-08-02 15:56:15 +02:00
Rusty Russell
641876a20a ccan: update to latest. 
configurator failed under clang:

checking for #pragma omp and -fopenmp support... ccan/tools/configurator/configurator: Test for HAVE_OPENMP failed with 32512:
./configurator.out: error while loading shared libraries: libomp.so: cannot open shared object file: No such file or directory

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-08-02 15:56:15 +02:00
Rusty Russell
0d2a4830ed ccan: update to faster and correct crc32c implementation. 
I decided to try a faster implementation, only to find our crc32c was
not correct!  Ouch.

I removed the crc32c functions from ccan/crc, and added a new crc32c
module which has the Mark Adler x86-64-optimized variants.

We bump gossip_store version again, since csums have changed.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-06-11 23:40:10 +00:00
Rusty Russell
3c13369431 ccan: update to get smaller htable implementation. 
MCP results from 5 runs, min-max(mean +/- stddev):
	store_rewrite_sec:46.750000-48.280000(47.512+/-0.51)
	listnodes_sec:1.100000-1.400000(1.192+/-0.11)
	listchannels_sec:49.530000-56.410000(53.914+/-2.3)
	routing_sec:29.500000-32.970000(30.392+/-1.3)
	peer_write_all_sec:50.760000-52.140000(51.348+/-0.59)

MCP notable changes from previous patch (>1 stddev):
-	vsz_kb:2639240
+	vsz_kb:2638880
 2019-04-09 12:37:16 -07:00
Rusty Russell
a319439957 ccan: update to get ccan/io exclusive helpers. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-04-08 01:56:17 +00:00
Rusty Russell
0361f43ec3 ccan: update 
Brings in fixes for closing stderr in parent for pipecmd (oops!)
and configurator fix (which we don't need yet)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2019-02-07 13:05:59 +01:00
Rusty Russell
8e7c8a18df ccan: update to latest version, which includes more take() checks. 
And add the missing unit test from my previous update.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-12-18 12:17:27 +01:00
Rusty Russell
6da213be31 ccan: update to get updated pipecmd. 
Note that this changes the order of arguments to pipecmd to match the
documentation, so we fix all the callers!

Also make configure re-run when configurator changes.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-12-10 00:00:50 +00:00
Christian Decker
045f7ce7f7 ccan: Update ccan modules to include incomplete option parsing 
Signed-off-by: Christian Decker <@cdecker>
 2018-11-13 00:44:50 +01:00
Rusty Russell
cd8446f081 ccan: update to get new ccan/io which sets errno to 0 on EOF. 
We get structeq and htable updates we don't need for free.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-10-19 00:53:00 +00:00
Rusty Russell
acc01e6436 ccan: update. 
This was from a different series, so I just cherry-picked it.

It adds ccan/membuf as a depenency of ccan/rbuf, though we don't use
it directly yet.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-10-19 00:53:00 +00:00
Rusty Russell
c02ab124aa ccan: update so we can apply notifiers to toplevel "NULL". 
This will make leak detection more thorough.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-08-24 19:54:32 +02:00
Rusty Russell
5179025977 ccan: upgrade to new ccan/tal and ccan/tal/str. 
The visible changes are:
1. tal_len() is renamed to tal_bytelen() for clarity.
2. tal allocations *always* know their length.
3. tal/str routines always set the length to strlen() + 1.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-07-30 11:31:17 +02:00
Rusty Russell
fed5a117e7 Update ccan/structeq. 
structeq() is too dangerous: if a structure has padding, it can fail
silently.

The new ccan/structeq instead provides a macro to define foo_eq(),
which does the right thing in case of padding (which none of our
structures currently have anyway).

Upgrade ccan, and use it everywhere.  Except run-peer-wire.c, which
is only testing code and can use raw memcmp(): valgrind will tell us
if padding exists.

Interestingly, we still declared short_channel_id_eq, even though
we didn't define it any more!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-07-04 23:57:00 +02:00
Rusty Russell
2639b1e9a9 ccan: add UTF-8 module for checking alias fields. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-07-01 14:55:29 +02:00
Rusty Russell
d395b58ffa ccan: update to have new configurator. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-06-08 17:56:01 +02:00
nicolas.dorier
59154ebd34 Fix build on linux-musl 
[ Done by updating CCAN with the ccan/endian fix --RR ]
 2018-05-15 05:54:15 +00:00
Rusty Russell
9c3691340f ccan: update to more recent version. 
In particular, this gets some MacOS fixes from #1327.
It also includes a major intmap update which fixes corner cases in traversals,
and requires ccan/bitops.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-04-06 13:34:27 +02:00
Rusty Russell
629c3db421 ccan: update to get tal_free fix. 
This allows us to make heirarchy loops, such as reference counting to
free our own parent.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-03-03 19:29:35 +01:00
Rusty Russell
8c2a556f55 ccan: update so we get configurator with --configurator-cc= arg. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-02-26 15:01:02 +01:00
Rusty Russell
ccd0e5db54 ccan: update so we get exposed path constants. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-02-16 13:02:41 +01:00
Rusty Russell
736a80db08 ccan: update so ccan/io doesn't exit when we get signals. 
In particular, we're going to capture SIGUSR1.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-02-07 00:46:49 +00:00
Rusty Russell
a8f033f6ae ccan: update to get new ccan/io changes. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-10-25 18:34:35 +02:00
Rusty Russell
2374b54ef2 ccan: update to get io fix for duplex pipes. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-10-20 18:31:32 +02:00
Rusty Russell
c92dd56dd5 ccan: update for better tal debugging checks. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-09-04 20:46:26 +02:00
Rusty Russell
1ffb9f07c1 ccan: update to latest shachain. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-08-20 13:06:41 +09:30
Rusty Russell
35ec22b946 ccan: update to expose io_fd_block() from ccan/io. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-07-12 10:21:16 +09:30
Rusty Russell
7f0d54533a ccan: update to fix io_wake bug. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-06-07 09:19:04 +09:30
Rusty Russell
83466b2b32 ccan: update to get close option to io/fdpass. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-03-20 07:50:53 +10:30
Rusty Russell
ad82d29379 ccan: update to get tal_len(NULL) 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-01-25 11:03:55 +10:30
Rusty Russell
1ba7f59d31 ccan: updates to get constant STR_MAX_CHARS and io_close_taken_fd. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-01-10 15:19:33 +10:30
Rusty Russell
f8344baf64 ccan: update, new modules. 
ccan/autodata, ccan/breakpoint, ccan/crypto/hmac_sha256, ccan/crypto/hkdf_sha256,
ccan/fdpass and ccan/io/fdpass.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2017-01-04 13:16:47 +10:30