mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-10 17:19:15 +01:00
Code Issues Projects Releases Wiki Activity

bolt11: return error on unexpected lightning prefix

Browse source 
Remove the assertion so that an error is returned for invalid bech32.
An error is preferable to crashing the entire node if there's an extra
"lightning:" prefix:

  $ lightning-cli pay "lightning:lightning:"

Node log:
  pay: common/bolt11.c:718: bolt11_decode_nosig: Assertion `!has_lightning_prefix(str)' failed.
  pay: FATAL SIGNAL 6
  ...
  INFO    plugin-pay: Killing plugin: exited during normal operation
  **BROKEN** plugin-pay: Plugin marked as important, shutting down lightningd
This commit is contained in:
Matt Morehouse 2023-10-17 11:29:18 -05:00 • committed by Rusty Russell
parent 74b8fff3d4
commit ee8cf69f28
3 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
common/bolt11.c
View file

@ -721,7 +721,6 @@ struct bolt11 *bolt11_decode_nosig(const tal_t *ctx, const char *str,
memset(have_field, 0, sizeof(have_field));
b11->routes = tal_arr(b11, struct route_info *, 0);
assert(!has_lightning_prefix(str));
if (strlen(str) < 8)
return decode_fail(b11, fail, "Bad bech32 string");

1
tests/fuzz/corpora/fuzz-bolt11/crash-98a2112c93362e35310c629081b5d60390062962 Normal file
View file

@ -0,0 +1 @@
lightning:

6
tests/fuzz/fuzz-bolt11.c
View file

@ -102,12 +102,6 @@ size_t LLVMFuzzerCustomMutator(uint8_t *fuzz_data, size_t size, size_t max_size,
return initial_input(fuzz_data, size, max_size);
}
// Strip (repeated) "lightning:" prefixes
while (strstarts(output, "lightning:") ||
strstarts(output, "LIGHTNING:")) {
output = (char *)to_canonical_invstr(tmpctx, output);
}
// Write the result into `fuzz_data`.
size_t output_len = strlen(output);
if (output_len > max_size)