mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-19 18:11:28 +01:00
Code Issues Projects Releases Wiki Activity

plugin/clnrest: do not read json payload if data length is zero

Browse Source 
OpenAPI readme always includes `content-type: application/json` header, even when body parameters are empty.
But the server expects data if the content-type has been sent.
This results in a "Server Error" response for non-param requests from readme doc.
This only affects readme requests as it is designed to send the header by default.

Changelog-None
This commit is contained in:
ShahanaFarooqui 2023-08-29 16:45:55 -07:00 committed by Rusty Russell
parent f4f4ab34f3
commit e788f76f99
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/clnrest/utilities/rpc_routes.py
View File

@ -48,7 +48,10 @@ class RpcMethodResource(Resource):
try: try:
if request.is_json: if request.is_json:
if len(request.data) != 0:
payload = request.get_json() payload = request.get_json()
else:
payload = {}
else: else:
payload = request.form.to_dict() payload = request.form.to_dict()
return call_rpc_method(plugin, rpc_method, payload), 201 return call_rpc_method(plugin, rpc_method, payload), 201

3
plugins/clnrest/utilities/shared.py
View File

@ -53,7 +53,10 @@ def verify_rune(plugin, request):
raise Exception('{ "error": {"code": 403, "message": "Not authorized: Missing rune"} }') raise Exception('{ "error": {"code": 403, "message": "Not authorized: Missing rune"} }')
if request.is_json: if request.is_json:
if len(request.data) != 0:
rpc_params = request.get_json() rpc_params = request.get_json()
else:
rpc_params = {}
else: else:
rpc_params = request.form.to_dict() rpc_params = request.form.to_dict()