mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 11:59:16 +01:00
Code Issues Projects Releases Wiki Activity

lightningd: add extra debugging for weird onchain htlc interactions.

Browse source 
This doesn't actually fix anything, but may shed more clues if it
happens again.

The broken() logs are overzealous, see next patch.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2022-03-30 14:13:12 +10:30
parent 5033e22835
commit e616b4fff7
1 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
lightningd/peer_htlcs.c
View file

@ -1418,13 +1418,23 @@ void onchain_failed_our_htlc(const struct channel *channel,
struct lightningd *ld = channel->peer->ld;
struct htlc_out *hout;
log_debug(channel->log, "onchain_failed_our_htlc");
hout = find_htlc_out(&ld->htlcs_out, channel, htlc->id);
if (!hout)
if (!hout) {
log_broken(channel->log, "HTLC id %"PRIu64" not found!",
htlc->id);
return;
}
/* Don't fail twice (or if already succeeded)! */
if (hout->failonion || hout->failmsg || hout->preimage)
if (hout->failonion || hout->failmsg || hout->preimage) {
log_debug(channel->log, "HTLC id %"PRIu64" failonion = %p, failmsg = %p, preimage = %p",
htlc->id,
hout->failonion,
hout->failmsg,
hout->preimage);
return;
}
hout->failmsg = towire_permanent_channel_failure(hout);
@ -1441,6 +1451,8 @@ void onchain_failed_our_htlc(const struct channel *channel,
hout->failmsg, &we_filled);
if (hout->am_origin) {
log_debug(channel->log, "HTLC id %"PRIu64" am origin",
htlc->id);
assert(why != NULL);
char *localfail = tal_fmt(channel, "%s: %s",
onion_wire_name(WIRE_PERMANENT_CHANNEL_FAILURE),
@ -1448,6 +1460,8 @@ void onchain_failed_our_htlc(const struct channel *channel,
payment_failed(ld, hout, localfail);
tal_free(localfail);
} else if (hout->in) {
log_debug(channel->log, "HTLC id %"PRIu64" has incoming",
htlc->id);
local_fail_in_htlc(hout->in,
take(towire_permanent_channel_failure(NULL)));
wallet_forwarded_payment_add(hout->key.channel->peer->ld->wallet,
@ -1456,7 +1470,9 @@ void onchain_failed_our_htlc(const struct channel *channel,
hout->failmsg
? fromwire_peektype(hout->failmsg)
: 0);
}
} else
log_broken(channel->log, "HTLC id %"PRIu64" is from nowhere?",
htlc->id);
}
static void remove_htlc_in(struct channel *channel, struct htlc_in *hin)