From e420bfd6a80c7b285b022614d7d0340ead01637e Mon Sep 17 00:00:00 2001 From: Christian Decker Date: Fri, 10 Jul 2020 20:01:39 +0200 Subject: [PATCH] pytest: Skip test_lockup_drain if VALGRIND and not DEVELOPER The test was failing very reliably, by not raising the expected exception. My best guess is that it needs more synchronization to cause the issue. --- tests/test_pay.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_pay.py b/tests/test_pay.py index eb0987329..8beffd502 100644 --- a/tests/test_pay.py +++ b/tests/test_pay.py @@ -6,7 +6,7 @@ from pyln.client import RpcError, Millisatoshi from pyln.proto.onion import TlvPayload from utils import ( DEVELOPER, wait_for, only_one, sync_blockheight, TIMEOUT, - EXPERIMENTAL_FEATURES, env + EXPERIMENTAL_FEATURES, env, VALGRIND ) import copy import os @@ -2320,6 +2320,7 @@ def test_channel_spendable_receivable_capped(node_factory, bitcoind): assert l2.rpc.listpeers()['peers'][0]['channels'][0]['receivable_msat'] == Millisatoshi(0xFFFFFFFF) +@unittest.skipIf(not DEVELOPER and VALGRIND, "Doesn't raise exception, needs better sync") def test_lockup_drain(node_factory, bitcoind): """Try to get channel into a state where opener can't afford fees on additional HTLC, so peer can't add HTLC""" l1, l2 = node_factory.line_graph(2, opts={'may_reconnect': True})