From dbcdfd7d6632f82d0a917d1377763b059ae3625d Mon Sep 17 00:00:00 2001 From: niftynei Date: Tue, 31 Oct 2023 15:09:06 -0500 Subject: [PATCH] dualfund, memleak: don't leak the msg on error We don't let go of the `msg` on error, which triggers a memleak warning! lightningd-2 2023-10-31T19:54:06.582Z **BROKEN** lightningd: MEMLEAK: 0x55ae3615b498 lightningd-2 2023-10-31T19:54:06.582Z **BROKEN** lightningd: label=openingd/dualopend_wiregen.c:919:u8[] lightningd-2 2023-10-31T19:54:06.582Z **BROKEN** lightningd: alloc: lightningd-2 2023-10-31T19:54:06.685Z **BROKEN** lightningd: ccan/ccan/tal/tal.c:477 (tal_alloc_) lightningd-2 2023-10-31T19:54:06.686Z **BROKEN** lightningd: ccan/ccan/tal/tal.c:506 (tal_alloc_arr_) lightningd-2 2023-10-31T19:54:06.686Z **BROKEN** lightningd: openingd/dualopend_wiregen.c:919 (towire_dualopend_send_tx_sigs) lightningd-2 2023-10-31T19:54:06.686Z **BROKEN** lightningd: lightningd/dual_open_control.c:1122 (openchannel2_sign_hook_cb) lightningd-2 2023-10-31T19:54:06.686Z **BROKEN** lightningd: lightningd/plugin_hook.c:194 (plugin_hook_call_next) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: lightningd/plugin_hook.c:169 (plugin_hook_callback) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: lightningd/plugin.c:660 (plugin_response_handle) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: lightningd/plugin.c:772 (plugin_read_json_one) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: lightningd/plugin.c:823 (plugin_read_json) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: ccan/ccan/io/io.c:59 (next_plan) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: ccan/ccan/io/io.c:407 (do_plan) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: ccan/ccan/io/io.c:417 (io_ready) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: ccan/ccan/io/poll.c:453 (io_loop) lightningd-2 2023-10-31T19:54:06.687Z **BROKEN** lightningd: lightningd/io_loop_with_timers.c:22 (io_loop_with_timers) lightningd-2 2023-10-31T19:54:06.688Z **BROKEN** lightningd: lightningd/lightningd.c:1333 (main) lightningd-2 2023-10-31T19:54:06.688Z **BROKEN** lightningd: ../sysdeps/nptl/libc_start_call_main.h:58 (__libc_start_call_main) lightningd-2 2023-10-31T19:54:06.688Z **BROKEN** lightningd: ../csu/libc-start.c:392 (__libc_start_main_impl) lightningd-2 2023-10-31T19:54:06.688Z **BROKEN** lightningd: parents: --- lightningd/dual_open_control.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lightningd/dual_open_control.c b/lightningd/dual_open_control.c index 96754019f..648307f9b 100644 --- a/lightningd/dual_open_control.c +++ b/lightningd/dual_open_control.c @@ -1127,6 +1127,7 @@ send_msg: channel_saved_err_broken_reconn(channel, "dualopend daemon died" " before signed PSBT returned"); + tal_free(msg); return; } tal_del_destructor2(payload->dualopend,