From dabd6c6b702052e294f02630fae9b60302e0b979 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 8 Aug 2023 09:42:50 +0930 Subject: [PATCH] pytest: run splicing test on every run. EXPERIMENTAL_SPLICING=1 turns it on for *all* tests, to make sure we don't accidentally break those. But we can (and should!) run the splice test under every possible CI scenario. Signed-off-by: Rusty Russell --- tests/test_splicing.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test_splicing.py b/tests/test_splicing.py index 614c0f522..f59017454 100644 --- a/tests/test_splicing.py +++ b/tests/test_splicing.py @@ -1,13 +1,14 @@ from fixtures import * # noqa: F401,F403 -import os +from utils import TEST_NETWORK import pytest import unittest -@unittest.skipIf(os.environ.get("EXPERIMENTAL_SPLICING", '0') != '1', "Need experimental splicing turned on") +@pytest.mark.openchannel('v1') @pytest.mark.openchannel('v2') +@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need') def test_splice(node_factory, bitcoind): - l1, l2 = node_factory.line_graph(2, fundamount=1000000, wait_for_announce=True) + l1, l2 = node_factory.line_graph(2, fundamount=1000000, wait_for_announce=True, opts={'experimental-splicing': None}) chan_id = l1.get_channel_id(l2)