mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-18 21:35:11 +01:00
Code Issues Projects Releases Wiki Activity

pylightning - allow unicode symbols in the description to be passed as-is to the daemon

Browse Source 
addresses issue #2753.

Formatting the JSON with the default parameters will escape the unicode
symbols in a way that c-lightning won't allow, leading to an exception.

Changelog-Fixed: `pylightning` now handles unicode characters in JSON-RPC requests and responses correctly.
This commit is contained in:
Jarret Dyrbye 2019-09-02 15:29:56 -06:00 committed by Christian Decker
parent dc1f27c0b3
commit d712f732d8
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pyln-client/pyln/client/lightning.py
View File

@ -172,7 +172,7 @@ class UnixDomainSocketRpc(object):
self.next_id = 0
def _writeobj(self, sock, obj):
s = json.dumps(obj, cls=self.encoder_cls)
s = json.dumps(obj, ensure_ascii=False, cls=self.encoder_cls)
sock.sendall(bytearray(s, 'UTF-8'))
def _readobj(self, sock, buff=b''):

1
tests/test_misc.py
View File

@ -2000,7 +2000,6 @@ def test_new_node_is_mainnet(node_factory):
assert os.path.isfile(os.path.join(basedir, "lightningd-bitcoin.pid"))
@pytest.mark.xfail(strict=True)
def test_unicode_rpc(node_factory):
node = node_factory.get_node()
desc = "Some candy 🍬 and a nice glass of milk 🥛."