mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 20:09:18 +01:00
Code Issues Projects Releases Wiki Activity

plugins/pay: fix route scoring calculation.

Browse source 
It gave 0.  A lot.

Firstly, rmsat was often very small, because delays are often small.   Much
smaller than the actual fee.

We really just want to offset the bias and multiply it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2024-03-07 13:26:36 +10:30 • committed by Christian Decker
parent e6cf8c0a24
commit d5c576bd69
1 changed files with 21 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
plugins/libplugin-pay.c
View file

@ -771,14 +771,29 @@ static u64 route_score(u32 distance,
int dir,
const struct gossmap_chan *c)
{
u64 cmsat = cost.millisatoshis; /* Raw: lengthy math */
u64 rmsat = risk.millisatoshis; /* Raw: lengthy math */
/* We multiply this, so 1 is neutral, higher is a penalty. */
double bias = capacity_bias(global_gossmap, c, dir, cost) + 1;
double costs;
struct amount_msat msat;
/* Smoothed harmonic mean to avoid division by 0 */
double costs = (cmsat * rmsat * bias) / (cmsat + rmsat + bias + 1);
/* These two are comparable, so simply sum them. */
if (!amount_msat_add(&msat, cost, risk))
msat = AMOUNT_MSAT(-1ULL);
/* Slight tiebreaker bias: 1 msat per distance */
if (!amount_msat_add(&msat, msat, amount_msat(distance)))
msat = AMOUNT_MSAT(-1ULL);
/* Percent penalty at different channel capacities:
* 1%: 1%
* 10%: 11%
* 25%: 29%
* 50%: 69%
* 75%: 138%
* 90%: 230%
* 95%: 300%
* 99%: 461%
*/
costs = (capacity_bias(global_gossmap, c, dir, cost) + 1)
* msat.millisatoshis; /* Raw: Weird math */
if (costs > 0xFFFFFFFF)
return 0xFFFFFFFF;
return (u64)costs;