mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 11:59:16 +01:00
Code Issues Projects Releases Wiki Activity

lightningd: use return value of peer_start_channeld()

Browse source 
It tells us if it's failed, so we should use that rather than
reporting failure twice.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2024-04-19 14:15:16 +09:30
parent 86c29b6acc
commit cd7175be88
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lightningd/opening_control.c
View file

@ -453,8 +453,11 @@ static void opening_funder_finished(struct subd *openingd, const u8 *resp,
if (pbase)
wallet_penalty_base_add(ld->wallet, channel->dbid, pbase);
/* If this fails, it cleans up */
if (!peer_start_channeld(channel, peer_fd, NULL, false, NULL))
return;
funding_success(channel);
peer_start_channeld(channel, peer_fd, NULL, false, NULL);
cleanup:
/* Frees fc too */
@ -557,10 +560,9 @@ static void opening_fundee_finished(struct subd *openingd,
if (pbase)
wallet_penalty_base_add(ld->wallet, channel->dbid, pbase);
/* On to normal operation! */
peer_start_channeld(channel, peer_fd, fwd_msg, false, NULL);
tal_free(uc);
/* On to normal operation (frees if it fails!) */
if (peer_start_channeld(channel, peer_fd, fwd_msg, false, NULL))
tal_free(uc);
return;
failed: