mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 22:45:27 +01:00
Code Issues Projects Releases Wiki Activity

hsmd: extract and use common sign_all_inputs() helper.

Browse source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2018-09-20 12:36:42 +09:30 • committed by Christian Decker
parent e012e94ab2
commit cc48e794c9
1 changed files with 41 additions and 71 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

112
hsmd/hsmd.c
View file

@ -926,6 +926,39 @@ static void hsm_key_for_utxo(struct privkey *privkey, struct pubkey *pubkey,
} }
} }
static void sign_all_inputs(struct bitcoin_tx *tx, struct utxo **utxos)
{
u8 **scriptSigs = tal_arr(tmpctx, u8 *, tal_count(utxos));
assert(tal_count(tx->input) == tal_count(utxos));
for (size_t i = 0; i < tal_count(utxos); i++) {
struct pubkey inkey;
struct privkey inprivkey;
const struct utxo *in = utxos[i];
u8 *subscript, *wscript;
secp256k1_ecdsa_signature sig;
hsm_key_for_utxo(&inprivkey, &inkey, in);
wscript = p2wpkh_scriptcode(tmpctx, &inkey);
if (in->is_p2sh) {
subscript = bitcoin_redeem_p2sh_p2wpkh(tmpctx, &inkey);
scriptSigs[i] = bitcoin_scriptsig_p2sh_p2wpkh(tx, &inkey);
} else {
subscript = NULL;
scriptSigs[i] = NULL;
}
sign_tx_input(tx, i, subscript, wscript, &inprivkey, &inkey,
&sig);
tx->input[i].witness = bitcoin_witness_p2wpkh(tx, &sig, &inkey);
}
/* Now complete the transaction by attaching the scriptSigs where necessary */
for (size_t i = 0; i < tal_count(utxos); i++)
tx->input[i].script = scriptSigs[i];
}
/* Note that it's the main daemon that asks for the funding signature so it /* Note that it's the main daemon that asks for the funding signature so it
* can broadcast it. */ * can broadcast it. */
static struct io_plan *handle_sign_funding_tx(struct io_conn *conn, static struct io_plan *handle_sign_funding_tx(struct io_conn *conn,
@ -935,18 +968,16 @@ static struct io_plan *handle_sign_funding_tx(struct io_conn *conn,
u64 satoshi_out, change_out; u64 satoshi_out, change_out;
u32 change_keyindex; u32 change_keyindex;
struct pubkey local_pubkey, remote_pubkey; struct pubkey local_pubkey, remote_pubkey;
struct utxo **utxomap; struct utxo **utxos;
struct bitcoin_tx *tx; struct bitcoin_tx *tx;
u16 outnum; u16 outnum;
size_t i;
struct pubkey *changekey; struct pubkey *changekey;
u8 **scriptSigs;
/* FIXME: Check fee is "reasonable" */ /* FIXME: Check fee is "reasonable" */
if (!fromwire_hsm_sign_funding(tmpctx, msg_in, if (!fromwire_hsm_sign_funding(tmpctx, msg_in,
&satoshi_out, &change_out, &satoshi_out, &change_out,
&change_keyindex, &local_pubkey, &change_keyindex, &local_pubkey,
&remote_pubkey, &utxomap)) &remote_pubkey, &utxos))
return bad_req(conn, c, msg_in); return bad_req(conn, c, msg_in);
if (change_out) { if (change_out) {
@ -956,42 +987,12 @@ static struct io_plan *handle_sign_funding_tx(struct io_conn *conn,
changekey = NULL; changekey = NULL;
tx = funding_tx(tmpctx, &outnum, tx = funding_tx(tmpctx, &outnum,
cast_const2(const struct utxo **, utxomap), cast_const2(const struct utxo **, utxos),
satoshi_out, &local_pubkey, &remote_pubkey, satoshi_out, &local_pubkey, &remote_pubkey,
change_out, changekey, change_out, changekey,
NULL); NULL);
scriptSigs = tal_arr(tmpctx, u8*, tal_count(utxomap)); sign_all_inputs(tx, utxos);
for (i = 0; i < tal_count(utxomap); i++) {
struct pubkey inkey;
struct privkey inprivkey;
const struct utxo *in = utxomap[i];
u8 *subscript;
secp256k1_ecdsa_signature sig;
hsm_key_for_utxo(&inprivkey, &inkey, in);
if (in->is_p2sh)
subscript = bitcoin_redeem_p2sh_p2wpkh(tmpctx, &inkey);
else
subscript = NULL;
u8 *wscript = p2wpkh_scriptcode(tmpctx, &inkey);
sign_tx_input(tx, i, subscript, wscript, &inprivkey, &inkey,
&sig);
tx->input[i].witness = bitcoin_witness_p2wpkh(tx, &sig, &inkey);
if (utxomap[i]->is_p2sh)
scriptSigs[i] = bitcoin_scriptsig_p2sh_p2wpkh(tx, &inkey);
else
scriptSigs[i] = NULL;
}
/* Now complete the transaction by attaching the scriptSigs where necessary */
for (size_t i=0; i<tal_count(utxomap); i++)
tx->input[i].script = scriptSigs[i];
return req_reply(conn, c, take(towire_hsm_sign_funding_reply(NULL, tx))); return req_reply(conn, c, take(towire_hsm_sign_funding_reply(NULL, tx)));
} }
@ -1005,7 +1006,6 @@ static struct io_plan *handle_sign_withdrawal_tx(struct io_conn *conn,
u64 satoshi_out, change_out; u64 satoshi_out, change_out;
u32 change_keyindex; u32 change_keyindex;
struct utxo **utxos; struct utxo **utxos;
u8 **scriptSigs;
struct bitcoin_tx *tx; struct bitcoin_tx *tx;
struct ext_key ext; struct ext_key ext;
struct pubkey changekey; struct pubkey changekey;
@ -1022,41 +1022,11 @@ static struct io_plan *handle_sign_withdrawal_tx(struct io_conn *conn,
"Failed to get key %u", change_keyindex); "Failed to get key %u", change_keyindex);
pubkey_from_der(ext.pub_key, sizeof(ext.pub_key), &changekey); pubkey_from_der(ext.pub_key, sizeof(ext.pub_key), &changekey);
tx = withdraw_tx( tx = withdraw_tx(tmpctx, cast_const2(const struct utxo **, utxos),
tmpctx, cast_const2(const struct utxo **, utxos), scriptpubkey, satoshi_out,
scriptpubkey, satoshi_out, &changekey, change_out, NULL);
&changekey, change_out, NULL);
scriptSigs = tal_arr(tmpctx, u8*, tal_count(utxos)); sign_all_inputs(tx, utxos);
for (size_t i = 0; i < tal_count(utxos); i++) {
struct pubkey inkey;
struct privkey inprivkey;
const struct utxo *in = utxos[i];
u8 *subscript;
secp256k1_ecdsa_signature sig;
hsm_key_for_utxo(&inprivkey, &inkey, in);
if (in->is_p2sh || in->close_info != NULL)
subscript = bitcoin_redeem_p2sh_p2wpkh(tmpctx, &inkey);
else
subscript = NULL;
u8 *wscript = p2wpkh_scriptcode(tmpctx, &inkey);
sign_tx_input(tx, i, subscript, wscript, &inprivkey, &inkey,
&sig);
tx->input[i].witness = bitcoin_witness_p2wpkh(tx, &sig, &inkey);
if (utxos[i]->is_p2sh)
scriptSigs[i] = bitcoin_scriptsig_p2sh_p2wpkh(tx, &inkey);
else
scriptSigs[i] = NULL;
}
/* Now complete the transaction by attaching the scriptSigs where necessary */
for (size_t i=0; i<tal_count(utxos); i++)
tx->input[i].script = scriptSigs[i];
return req_reply(conn, c, return req_reply(conn, c,
take(towire_hsm_sign_withdrawal_reply(NULL, tx))); take(towire_hsm_sign_withdrawal_reply(NULL, tx)));