From c96cc8a444fee72fdb4cb2e3c5e05b8dbe334346 Mon Sep 17 00:00:00 2001 From: Christian Decker Date: Mon, 29 Apr 2019 19:26:04 +0200 Subject: [PATCH] pytest: Fix the flaky test_plugin_connected_hook test It was a bit eager :-) Signed-off-by: Christian Decker <@cdecker> --- tests/test_plugin.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/test_plugin.py b/tests/test_plugin.py index f59d41362..73aa82653 100644 --- a/tests/test_plugin.py +++ b/tests/test_plugin.py @@ -1,7 +1,7 @@ from collections import OrderedDict from fixtures import * # noqa: F401,F403 from lightning import RpcError, Millisatoshi -from utils import only_one +from utils import only_one, wait_for import os import pytest @@ -169,8 +169,11 @@ def test_plugin_connected_hook(node_factory): .format(l1.info['id'])) l3.daemon.wait_for_log(r"You are in reject list") - peer = l1.rpc.listpeers(l3.info['id'])['peers'] - assert(peer == [] or not peer[0]['connected']) + def check_disconnect(): + peers = l1.rpc.listpeers(l3.info['id'])['peers'] + return peers == [] or not peers[0]['connected'] + + wait_for(check_disconnect) def test_async_rpcmethod(node_factory, executor):