From bba9525cc3b9316aaa4efc6d71eb246e97c28425 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Mon, 31 Jan 2022 13:11:46 +1030 Subject: [PATCH] pytest: note unfixable test_htlc_rexmit_while_closing test. We really need our own lnprototest tests for packet-based stuff; these message-based tests are inherently delicate and awkward. In particular, connectd now does dev-disconnect, so the socket is not immediately closed after a dev-disconnect command. In this case, the WIRE_SHUTDOWN has often already been written from connectd to channeld. But it sometimes works, too. Signed-off-by: Rusty Russell --- tests/test_closing.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test_closing.py b/tests/test_closing.py index 61264648b..b273e2d6a 100644 --- a/tests/test_closing.py +++ b/tests/test_closing.py @@ -3442,6 +3442,7 @@ def test_closing_higherfee(node_factory, bitcoind, executor): @pytest.mark.developer("needs dev_disconnect") def test_htlc_rexmit_while_closing(node_factory, executor): """Retranmitting an HTLC revocation while shutting down should work""" + # FIXME: This should be in lnprototest! UNRELIABLE. # l1 disconnects after sending second COMMITMENT_SIGNED. # Then it stops receiving after sending WIRE_SHUTDOWN (which is before it # reads the revoke_and_ack).