mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-18 21:35:11 +01:00
Code Issues Projects Releases Wiki Activity

logging: Removed automatic subprocess logging for bitcoind

Browse Source 
This was responsible for a huge number of loglines simply because we
log every subprocess start and termination. Moving the logging
upstream to where it is really needed gets rid of the polling, that
are successful. A highly unscientific test shows a reduction in
loglines produced by lightningd from 17000 to 10000 lines.
This commit is contained in:
Christian Decker 2017-05-18 13:31:34 +02:00 committed by Rusty Russell
parent 80bf908922
commit b8ba8f003c
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
daemon/bitcoind.c
View File

@ -131,7 +131,6 @@ static void bcli_finished(struct io_conn *conn, struct bitcoin_cli *bcli)
} else
*bcli->exitstatus = WEXITSTATUS(status);
log_debug(bitcoind->log, "reaped %u: %s", ret, bcli_args(bcli));
bitcoind->req_running = false;
bcli->process(bcli);
@ -150,8 +149,6 @@ static void next_bcli(struct bitcoind *bitcoind)
if (!bcli)
return;
log_debug(bcli->bitcoind->log, "starting: %s", bcli_args(bcli));
bcli->pid = pipecmdarr(&bcli->fd, NULL, &bcli->fd, bcli->args);
if (bcli->pid < 0)
fatal("%s exec failed: %s", bcli->args[0], strerror(errno));
@ -296,6 +293,7 @@ void bitcoind_sendrawtx_(struct peer *peer,
int exitstatus, const char *msg, void *),
void *arg)
{
log_debug(bitcoind->log, "sendrawtransaction: %s", hextx);
start_bitcoin_cli(bitcoind, NULL, process_sendrawtx, true, cb, arg,
"sendrawtransaction", hextx, NULL);
}
@ -310,8 +308,6 @@ static void process_chaintips(struct bitcoin_cli *bcli)
struct sha256_double *tipid,
void *arg) = bcli->cb;
log_debug(bcli->bitcoind->log, "Got getchaintips result");
tokens = json_parse_input(bcli->output, bcli->output_bytes, &valid);
if (!tokens)
fatal("%s: %s response",