mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-21 14:24:09 +01:00
Code Issues Projects Releases Wiki Activity

pytest: fix flake in test_closing.py::test_penalty_htlc_tx_timeout

Browse source 
lightningd-3 penalizes lightningd-2 but then it can see the preimage for the HTLC which
has already been timed out:

```
2024-06-24T02:41:29.4633900Z lightningd-3 2024-06-24T02:33:54.073Z **BROKEN** 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-onchaind-chan#1: HTLC already resolved by THEIR_HTLC_TIMEOUT_TO_THEM when we found preimage
```

This is fair: the test deliberately takes l3 offline for long enough
that the HTLC can get timed out.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2024-06-24 13:11:04 +09:30
parent 80cde517c9
commit b748c1845c
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/test_closing.py
View file

@ -1397,6 +1397,8 @@ def test_penalty_htlc_tx_timeout(node_factory, bitcoind, chainparams, anchors):
'plugin': coin_mvt_plugin,
'dev-no-reconnect': None,
'may_reconnect': True,
# This can happen, if l2 collects htlc before we penalize.
'broken_log': 'HTLC already resolved by THEIR_HTLC_TIMEOUT_TO_THEM when we found preimage'
}, {
'dev-no-reconnect': None,
}, {