mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-03 18:57:06 +01:00
Code Issues Projects Releases Wiki Activity

plugin: simplify plugin dir test a little.

Browse source 
Check if it's a normal file first, then check permissions.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2018-12-08 10:59:56 +10:30
parent dc7b76e5e6
commit b484933b40
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lightningd/plugin.c
View file

@ -725,11 +725,11 @@ static const char *plugin_fullpath(const tal_t *ctx, const char *dir,
fullname = path_join(ctx, dir, basename); fullname = path_join(ctx, dir, basename);
if (stat(fullname, &st) != 0) if (stat(fullname, &st) != 0)
return tal_free(fullname); return tal_free(fullname);
if (!(st.st_mode & (S_IXUSR|S_IXGRP|S_IXOTH)) || st.st_mode & S_IFDIR) /* Only regular files please (or symlinks to such: stat not lstat!) */
if ((st.st_mode & S_IFMT) != S_IFREG)
return tal_free(fullname); return tal_free(fullname);
/* Must be executable by someone. */
/* Ignore directories, they have exec mode, but aren't executable. */ if (!(st.st_mode & (S_IXUSR|S_IXGRP|S_IXOTH)))
if (st.st_mode & S_IFDIR)
return tal_free(fullname); return tal_free(fullname);
return fullname; return fullname;
} }