mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-17 19:03:42 +01:00
Code Issues Projects Releases Wiki Activity

pyln.proto.message: python-fluency feedback from @darosior

Browse Source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2020-06-04 13:43:35 +09:30 committed by Christian Decker
parent 8f38bc7230
commit b33dc9847c
2 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
contrib/pyln-proto/pyln/proto/message/array_types.py
View File

@ -34,12 +34,7 @@ wants an array of some type.
if self.elemtype.name == 'byte':
return bytes(v).hex()
s = ''
sep = ''
for i in v:
s += sep + self.elemtype.val_to_str(i, otherfields)
sep = ','
s = ','.join(self.elemtype.val_to_str(i, otherfields) for i in v)
return '[' + s + ']'
def write(self, io_out, v, otherfields):

16
contrib/pyln-proto/pyln/proto/message/message.py
View File

@ -86,9 +86,9 @@ domain, such as within a given BOLT"""
def get_type(self, name):
t = self.get_fundamentaltype(name)
if not t:
if t is None:
t = self.get_subtype(name)
if not t:
if t is None:
t = self.get_tlvtype(name)
return t
@ -203,7 +203,7 @@ inherit from this too.
"""
basetype = namespace.get_type(parts[1])
if not basetype:
if basetype is None:
raise ValueError('Unknown type {}'.format(parts[1]))
# Fixed number, or another field.
@ -367,7 +367,7 @@ class MessageType(SubtypeType):
raise ValueError("msgdata expected 4 CSV parts, not {}"
.format(parts))
messagetype = namespace.get_msgtype(parts[0])
if not messagetype:
if messagetype is None:
raise ValueError("unknown subtype {}".format(parts[0]))
field = messagetype._field_from_csv(namespace, parts[1:4],
@ -405,7 +405,7 @@ confusingly) refers to them.
raise ValueError("tlvtype expected 4 CSV parts, not {}"
.format(parts))
tlvstream = namespace.get_tlvtype(parts[0])
if not tlvstream:
if tlvstream is None:
tlvstream = TlvStreamType(parts[0])
namespace.add_tlvtype(tlvstream)
@ -422,7 +422,7 @@ tlvdata,reply_channel_range_tlvs,timestamps_tlv,encoding_type,u8,
.format(parts))
tlvstream = namespace.get_tlvtype(parts[0])
if not tlvstream:
if tlvstream is None:
raise ValueError("unknown tlvtype {}".format(parts[0]))
field = tlvstream.find_field(parts[1])
@ -582,7 +582,7 @@ Returns None on EOF
return None
mtype = namespace.get_msgtype_by_number(typenum)
if not mtype:
if mtype is None:
raise ValueError('Unknown message type number {}'.format(typenum))
fields = {}
@ -605,7 +605,7 @@ Format is msgname [ field=...]*.
parts = s.split()
mtype = namespace.get_msgtype(parts[0])
if not mtype:
if mtype is None:
raise ValueError('Unknown message type name {}'.format(parts[0]))
args = {}