From b2206744c06be7d85278db566b1d047820d7e330 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Sat, 9 Oct 2021 16:23:29 +1030 Subject: [PATCH] pytest: fix flake when test reconnects by itself. If it reconnects by itself, it will get a warning message: ``` lightningd-2: 2021-10-08T01:40:42.446Z DEBUG 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#3: billboard: Sent reestablish, waiting for theirs lightningd-2: 2021-10-08T01:40:42.446Z DEBUG 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#3: peer_in WIRE_ERROR lightningd-2: 2021-10-08T01:40:42.447Z DEBUG 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#3: billboard perm: Received error channel 0a6220a3e904d17e72b5c3499928dc8a65720063c6395c999a129a0ff0b06afb: Forcibly closed by `close` command timeout lightningd-2: 2021-10-08T01:40:42.448Z INFO 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-chan#3: Peer transient failure in CHANNELD_NORMAL: channeld WARNING: error channel 0a6220a3e904d17e72b5c3499928dc8a65720063c6395c999a129a0ff0b06afb: Forcibly closed by `close` command timeout ``` And this will make CI complain. Signed-off-by: Rusty Russell --- tests/test_connection.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_connection.py b/tests/test_connection.py index 891a66123..8c4c94988 100644 --- a/tests/test_connection.py +++ b/tests/test_connection.py @@ -3523,10 +3523,12 @@ def test_upgrade_statickey(node_factory, executor): def test_upgrade_statickey_onchaind(node_factory, executor, bitcoind): """We test penalty before/after, and unilateral before/after""" l1, l2 = node_factory.line_graph(2, opts=[{'may_reconnect': True, + 'dev-no-reconnect': None, 'dev-force-features': ["-13", "-21"], # We try to cheat! 'allow_broken_log': True}, - {'may_reconnect': True}]) + {'may_reconnect': True, + 'dev-no-reconnect': None}]) # TEST 1: Cheat from pre-upgrade. tx = l1.rpc.dev_sign_last_tx(l2.info['id'])['tx']