mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 14:42:40 +01:00
Code Issues Projects Releases Wiki Activity

pay: Annotate suspended payments with the groupid they mirror

Browse source 
This should prevent us from accidentally completing a payment twice,
when replaying the result of an actual attempt against pay call that
was suspended due to it still being pending.
This commit is contained in:
Christian Decker 2022-08-03 16:45:44 +02:00 • committed by neil saitug
parent 80a6d9b58e
commit aca9c7d49c
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
plugins/pay.c
View file

@ -787,6 +787,10 @@ payment_listsendpays_previous(struct command *cmd, const char *buf,
u64 last_group = 0;
/* Do we have pending sendpays for the previous attempt? */
bool pending = false;
/* Group ID of the first pending payment, this will be the one
* who's result gets replayed if we end up suspending. */
u64 pending_group_id = 0;
/* Did a prior attempt succeed? */
bool completed = false;
@ -855,6 +859,11 @@ payment_listsendpays_previous(struct command *cmd, const char *buf,
status = json_get_member(buf, t, "status");
completed |= json_tok_streq(buf, status, "complete");
pending |= json_tok_streq(buf, status, "pending");
/* Remember the group id of the first pending group so
* we can replay its result later. */
if (!pending_group_id && pending)
pending_group_id = groupid;
}
if (completed) {
@ -874,7 +883,9 @@ payment_listsendpays_previous(struct command *cmd, const char *buf,
/* We suspend this call and wait for the
* `on_payment_success` or `on_payment_failure`
* handler of the currently running payment to notify
* us about its completion. */
* us about its completion. We latch on to the result
* from the call we extracted above. */
p->groupid = pending_group_id;
return command_still_pending(cmd);
}
p->groupid = last_group + 1;