mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 22:45:27 +01:00
Code Issues Projects Releases Wiki Activity

add a log message when it is not possible upgrade the db

Browse source 
People are upgrading to 22.11.1 not, and in some configurations like the one
mentioned in the issue, we should
put some info information in the log when we are not able to upgrade.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This commit is contained in:
Vincenzo Palazzo 2023-02-08 20:17:23 +01:00 • committed by Alex Myers
parent b6a7532625
commit a610f28ad4
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
wallet/db.c
View file

@ -958,6 +958,7 @@ static bool db_migrate(struct lightningd *ld, struct db *db,
{ {
/* Attempt to read the version from the database */ /* Attempt to read the version from the database */
int current, orig, available; int current, orig, available;
char *err_msg;
struct db_stmt *stmt; struct db_stmt *stmt;
const struct migration_context mc = { const struct migration_context mc = {
.bip32_base = bip32_base, .bip32_base = bip32_base,
@ -969,16 +970,22 @@ static bool db_migrate(struct lightningd *ld, struct db *db,
if (current == -1) if (current == -1)
log_info(ld->log, "Creating database"); log_info(ld->log, "Creating database");
else if (available < current) else if (available < current) {
db_fatal("Refusing to migrate down from version %u to %u", err_msg = tal_fmt(tmpctx, "Refusing to migrate down from version %u to %u",
current, available); current, available);
else if (current != available) { log_info(ld->log, "%s", err_msg);
db_fatal("%s", err_msg);
} else if (current != available) {
if (ld->db_upgrade_ok && *ld->db_upgrade_ok == false) { if (ld->db_upgrade_ok && *ld->db_upgrade_ok == false) {
db_fatal("Refusing to upgrade db from version %u to %u (database-upgrade=false)", err_msg = tal_fmt(tmpctx, "Refusing to upgrade db from version %u to %u (database-upgrade=false)",
current, available); current, available);
log_info(ld->log, "%s", err_msg);
db_fatal("%s", err_msg);
} else if (!ld->db_upgrade_ok && !is_released_version()) { } else if (!ld->db_upgrade_ok && !is_released_version()) {
db_fatal("Refusing to irreversibly upgrade db from version %u to %u in non-final version %s (use --database-upgrade=true to override)", err_msg = tal_fmt(tmpctx, "Refusing to irreversibly upgrade db from version %u to %u in non-final version %s (use --database-upgrade=true to override)",
current, available, version()); current, available, version());
log_info(ld->log, "%s", err_msg);
db_fatal("%s", err_msg);
} }
log_info(ld->log, "Updating database from version %u to %u", log_info(ld->log, "Updating database from version %u to %u",
current, available); current, available);