mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-21 22:31:48 +01:00
Code Issues Projects Releases Wiki Activity

autoclean: don't return a raw string as result.

Browse source 
This is hard to parse, and not extensible in future, and disagrees with
the man page (and caught by schema).

Technically this is an API break, but it can't be done neatly anyway
and it's unlikely someone is relying on this today :(

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: JSONRPC: `autocleaninvoice` now returns an object, not a raw string.
This commit is contained in:
Rusty Russell 2021-05-26 15:13:01 +09:30
parent 129d3f65e7
commit 97b52ed8c3
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
plugins/autoclean.c
View file

@ -39,6 +39,7 @@ static struct command_result *json_autocleaninvoice(struct command *cmd,
{
u64 *cycle;
u64 *exby;
struct json_stream *response;
if (!param(cmd, buffer, params,
p_opt_def("cycle_seconds", param_u64, &cycle, 3600),
@ -50,18 +51,19 @@ static struct command_result *json_autocleaninvoice(struct command *cmd,
expired_by = *exby;
if (cycle_seconds == 0) {
tal_free(cleantimer);
return command_success_str(cmd, "Autoclean timer disabled");
response = jsonrpc_stream_success(cmd);
json_add_bool(response, "enabled", false);
return command_finished(cmd, response);
}
tal_free(cleantimer);
cleantimer = plugin_timer(cmd->plugin, time_from_sec(cycle_seconds),
do_clean, cmd->plugin);
return command_success_str(cmd,
tal_fmt(cmd, "Autocleaning %"PRIu64
"-second old invoices every %"PRIu64
" seconds",
expired_by, cycle_seconds));
response = jsonrpc_stream_success(cmd);
json_add_bool(response, "enabled", true);
json_add_u64(response, "cycle_seconds", cycle_seconds);
json_add_u64(response, "expired_by", expired_by);
return command_finished(cmd, response);
}
static const char *init(struct plugin *p,