mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 22:45:27 +01:00
Code Issues Projects Releases Wiki Activity

jsonrpc: fix error when we abort batching due to timeout.

Browse source 
The read_json() call expects len_read to be the amount of *new*
data read.  If we call this back without resetting, it will parse
this much random junk in the buffer.

Fixes: #5766
Changelog-Fixed: Plugin: `autoclean` could misperform or get killed due to lightningd's invalid handling of JSON batching.
This commit is contained in:
Rusty Russell 2022-12-06 05:35:04 +10:30 • committed by Christian Decker
parent 24d7aad3d0
commit 9751502ff5
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lightningd/jsonrpc.c
View file

@ -1109,6 +1109,8 @@ again:
start_time), start_time),
time_from_msec(250))) { time_from_msec(250))) {
db_commit_transaction(jcon->ld->wallet->db); db_commit_transaction(jcon->ld->wallet->db);
/* Call us back, as if we read nothing new */
jcon->len_read = 0;
return io_always(conn, read_json, jcon); return io_always(conn, read_json, jcon);
} }
} }