mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-01 17:47:30 +01:00
Code Issues Projects Releases Wiki Activity

pytest: Fix racy test_unreachable_routehint

Browse source 
It was failing likely because we were racing on the log
processing. Using `wait_for_log` instead should address that.
This commit is contained in:
Christian Decker 2021-04-22 16:48:54 +02:00 • committed by Rusty Russell
parent 0060dc733c
commit 9470ea3032
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/test_pay.py
View file

@ -4210,11 +4210,11 @@ def test_unreachable_routehint(node_factory, bitcoind):
with pytest.raises(RpcError, match=r'Destination [a-f0-9]{66} is not reachable'): with pytest.raises(RpcError, match=r'Destination [a-f0-9]{66} is not reachable'):
l1.rpc.pay(invoice) l1.rpc.pay(invoice)
assert(l1.daemon.is_in_log( l1.daemon.wait_for_log(
r"Removed routehint 0 because entrypoint {entrypoint} is unknown.".format( r"Removed routehint 0 because entrypoint {entrypoint} is unknown.".format(
entrypoint=entrypoint entrypoint=entrypoint
) )
)) )
# Now connect l2 to l3 to create a bridge, but without a # Now connect l2 to l3 to create a bridge, but without a
# channel. The entrypoint will become known, but still # channel. The entrypoint will become known, but still
@ -4225,11 +4225,13 @@ def test_unreachable_routehint(node_factory, bitcoind):
with pytest.raises(RpcError, match=r'Destination [a-f0-9]{66} is not reachable') as excinfo: with pytest.raises(RpcError, match=r'Destination [a-f0-9]{66} is not reachable') as excinfo:
l1.rpc.pay(invoice) l1.rpc.pay(invoice)
assert(l1.daemon.is_in_log(
# Verify that we failed for the correct reason.
l1.daemon.wait_for_log(
r"Removed routehint 0 because entrypoint {entrypoint} is unreachable.".format( r"Removed routehint 0 because entrypoint {entrypoint} is unreachable.".format(
entrypoint=entrypoint entrypoint=entrypoint
) )
)) )
# Since we aborted once we realized the destination is unreachable # Since we aborted once we realized the destination is unreachable
# both directly, and via the routehints we should now just have a # both directly, and via the routehints we should now just have a