mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 14:42:40 +01:00
Code Issues Projects Releases Wiki Activity

pytest: add test for db crash on conflicting invoice.id

Browse source 
```
2023-07-26T14:26:37.504Z BROKEN lightningd: Error executing statement: wallet/invoices.c:282: INSERT INTO invoices ( id, payment_hash, payment_key, state , msatoshi, label, expiry_time , pay_index, msatoshi_received , paid_timestamp, bolt11, description, features, local_offer_id) VALUES ( ?, ?, ?, ? , ?, ?, ? , NULL, NULL , NULL, ?, ?, ?, ?);: UNIQUE constraint failed: invoices.id
```

Reported-by: https://github.com/hMsats
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2023-07-27 09:44:14 +09:30
parent 7b8ea7f60a
commit 909bed6a30
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
tests/data/invoices_pre_waitindex.sqlite3.xz Normal file
View file

Binary file not shown.

14
tests/test_invoices.py
View file

@ -911,3 +911,17 @@ def test_listinvoices_index(node_factory, executor):
# limit should work!
for i in range(1, 10):
assert only_one(l2.rpc.listinvoices(index='updated', start=i, limit=1)['invoices'])['label'] == str(70 + 1 - i)
@pytest.mark.xfail(strict=True)
@unittest.skipIf(TEST_NETWORK != 'regtest', "The DB migration is network specific due to the chain var.")
def test_invoices_wait_db_migration(node_factory, bitcoind):
"""Canned db is from v23.02.2's test_invoice_routeboost_private l2"""
bitcoind.generate_block(28)
l2 = node_factory.get_node(node_id=2,
dbfile='invoices_pre_waitindex.sqlite3.xz',
options={'database-upgrade': True})
# And now we crash:
# Error executing statement: wallet/invoices.c:282: INSERT INTO invoices ( id, payment_hash, payment_key, state , msatoshi, label, expiry_time , pay_index, msatoshi_received , paid_timestamp, bolt11, description, features, local_offer_id) VALUES ( ?, ?, ?, ? , ?, ?, ? , NULL, NULL , NULL, ?, ?, ?, ?);: UNIQUE constraint failed: invoices.id
l2.rpc.invoice(1000, "test", "test")