mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 20:09:18 +01:00
Code Issues Projects Releases Wiki Activity

offers: fix crash when receiving response to offer without offer_issuer_id

Browse source 
Now we actually check the other fields too, as per BOLT!

Reported-by: https://github.com/hMsats
Fixes: #7513
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2024-08-05 14:09:14 +09:30 • committed by ShahanaFarooqui
parent 28b93e1b5f
commit 8dbc1c5f2e
1 changed files with 25 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
plugins/fetchinvoice.c
View file

@ -220,6 +220,29 @@ static struct command_result *handle_invreq_response(struct command *cmd,
goto badinv;
}
/* BOLT-offers #12:
* A reader of an invoice:
* - MUST reject the invoice if `invoice_amount` is not present.
* - MUST reject the invoice if `invoice_created_at` is not present.
* - MUST reject the invoice if `invoice_payment_hash` is not present.
* - MUST reject the invoice if `invoice_node_id` is not present.
*/
if (!inv->invoice_amount) {
badfield = "invoice_amount";
goto badinv;
}
if (!inv->invoice_created_at) {
badfield = "invoice_amount";
goto badinv;
}
if (!inv->invoice_payment_hash) {
badfield = "invoice_payment_hash";
goto badinv;
}
if (!inv->invoice_node_id) {
badfield = "invoice_node_id";
goto badinv;
}
/* BOLT-offers #12:
* - if `offer_issuer_id` is present (invoice_request for an offer):
* - MUST reject the invoice if `invoice_node_id` is not equal to `offer_issuer_id`
@ -227,7 +250,8 @@ static struct command_result *handle_invreq_response(struct command *cmd,
* - MUST reject the invoice if `invoice_node_id` is not equal to the final
* `blinded_node_id` it sent the `invoice_request` to.
*/
if (!inv->invoice_node_id || !pubkey_eq(inv->offer_issuer_id, sent->issuer_key)) {
/* Either way, we save the expected id in issuer_key */
if (!pubkey_eq(inv->invoice_node_id, sent->issuer_key)) {
badfield = "invoice_node_id";
goto badinv;
}
@ -245,15 +269,6 @@ static struct command_result *handle_invreq_response(struct command *cmd,
goto badinv;
}
/* BOLT-offers #12:
* A reader of an invoice:
* - MUST reject the invoice if `invoice_amount` is not present.
*/
if (!inv->invoice_amount) {
badfield = "invoice_amount";
goto badinv;
}
/* Get the amount we expected: firstly, if that's what we sent,
* secondly, if specified in the invoice. */
if (inv->invreq_amount) {