mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 11:59:16 +01:00
Code Issues Projects Releases Wiki Activity

reckless-rpc: catch failed reckless subprocess

Browse source 
... before processing the output. It's probably a python backtrace, not
json anyway.
This commit is contained in:
Alex Myers 2024-08-07 18:22:36 -05:00 • committed by ShahanaFarooqui
parent 1cb478d2c7
commit 88504ea6d2
1 changed files with 32 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
plugins/recklessrpc.c
View file

@ -120,26 +120,52 @@ static struct command_result *reckless_result(struct io_conn *conn,
return command_finished(reckless->cmd, response);
}
static struct command_result *reckless_fail(struct reckless *reckless,
char *err)
{
struct json_stream *resp;
resp = jsonrpc_stream_fail(reckless->cmd, PLUGIN_ERROR, err);
return command_finished(reckless->cmd, resp);
}
static void reckless_conn_finish(struct io_conn *conn,
struct reckless *reckless)
{
/* FIXME: avoid EBADFD - leave stdin fd open? */
if (errno && errno != 9)
plugin_log(plugin, LOG_DBG, "err: %s", strerror(errno));
reckless_result(conn, reckless);
if (reckless->pid > 0) {
int status;
int status = 0;
pid_t p;
p = waitpid(reckless->pid, &status, WNOHANG);
/* Did the reckless process exit? */
if (p != reckless->pid && reckless->pid) {
plugin_log(plugin, LOG_DBG, "reckless failed to exit "
"(%i), killing now.", status);
plugin_log(plugin, LOG_DBG, "reckless failed to exit, "
"killing now.");
kill(reckless->pid, SIGKILL);
reckless_fail(reckless, "reckless process hung");
/* Reckless process exited and with normal status? */
} else if (WIFEXITED(status) && !WEXITSTATUS(status)) {
plugin_log(plugin, LOG_DBG,
"Reckless subprocess complete: %s",
reckless->stdoutbuf);
reckless_result(conn, reckless);
/* Don't try to process json if python raised an error. */
} else {
plugin_log(plugin, LOG_DBG,
"Reckless process has crashed (%i).",
WEXITSTATUS(status));
char * err;
if (reckless->process_failed)
err = reckless->process_failed;
else
err = tal_strdup(tmpctx, "the reckless process "
"has crashed");
reckless_fail(reckless, err);
plugin_log(plugin, LOG_UNUSUAL,
"The reckless subprocess has failed.");
}
}
plugin_log(plugin, LOG_DBG, "Reckless subprocess complete.");
plugin_log(plugin, LOG_DBG, "output: %s", reckless->stdoutbuf);
io_close(conn);
tal_free(reckless);
}