mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 06:41:44 +01:00
Code Issues Projects Releases Wiki Activity

chaintopology: Add missing block_map_del.

Browse source 
We would `block_map_add` inside `add_tip`, but we never
`block_map_del` inside `remove_tip`, which is dangerous as
we actually `tal_free` the block inside `remove_tip`.

Our CI did not reliably trap this problem since block
hashes are random and rerunning the `test_blockchaintrack`
often passed spuriously.
This commit is contained in:
ZmnSCPxj 2018-03-15 23:23:14 +00:00 • committed by Rusty Russell
parent 39d8f64226
commit 7bbc1948f7
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lightningd/chaintopology.c
View file

@ -440,6 +440,7 @@ static void remove_tip(struct chain_topology *topo)
txwatch_fire(topo, b->txs[i], 0);
wallet_block_remove(topo->wallet, b);
block_map_del(&topo->block_map, b);
tal_free(b);
}