mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-19 01:43:36 +01:00
Code Issues Projects Releases Wiki Activity

jsmn: upgrade so JSMN_OBJECT's size parameter is usable.

Browse Source 
jsmn would accept invalid JSON objects.  This is bad because it would
set ->size incorrectly: we expect to have at least size * 2 tokens (in
pairs).  We want to rely on ->size, but this would create an exploitable
buffer overflow!

Fortunately, this is fixed upstream, so we add a test and upgrade to v1.0.0.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2019-01-17 12:39:45 +10:30 committed by Christian Decker
parent be8006a4fc
commit 7b59e26dd7
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
common/test/run-json.c
View File

@ -74,6 +74,11 @@ static void test_json_tok_size(void)
assert(toks[0].size == 2);
assert(toks[2].size == 2);
assert(toks[6].size == 2);
/* This should *not* parse! (used to give toks[0]->size == 2!) */
buf = "{ 'satoshi', '546' }";
toks = json_parse_input(tmpctx, buf, strlen(buf), &ok);
assert(!ok);
}
static void test_json_delve(void)

2
external/jsmn vendored

@ -1 +1 @@
Subproject commit 6784c826d9674915a4d89649c6288e6aecb4110d
Subproject commit 18e9fe42cbfe21d65076f5c77ae2be379ad1270f