mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 22:45:27 +01:00
Code Issues Projects Releases Wiki Activity

This commit fixes a bug introduced in 64b1ddd761 that does not

Browse source 
ignore the min fee as specified by the user setting.

We explicitly allow the user to ignore the fee limits, although this comes with inherent risks.

By enabling this option, users are explicitly
I was aware of the potential dangers.
There are situations, such as the one described in [1], where it
becomes necessary to bypass the fee limits to resolve issues like a stuck channel.

BTW experimental-anchors should fix this.

[1] https://github.com/ElementsProject/lightning/issues/6362

Reported-by: @pabpas
Fixes: 64b1ddd761
Link: https://github.com/ElementsProject/lightning/issues/6362
Changelog-Fixes: do not ignore the ignore-fee-limit option during
update_fee
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This commit is contained in:
Vincenzo Palazzo 2023-07-06 19:21:07 +02:00 • committed by Rusty Russell
parent a264e10564
commit 77d787b975
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lightningd/chaintopology.c
View file

@ -1137,7 +1137,19 @@ u32 feerate_min(struct lightningd *ld, bool *unknown)
if (unknown)
*unknown = false;
/* We can't allow less than feerate_floor, since that won't relay */
/* We allow the user to ignore the fee limits,
* although this comes with inherent risks.
*
* By enabling this option, users are explicitly
* made aware of the potential dangers.
* There are situations, such as the one described in [1],
* where it becomes necessary to bypass the fee limits to resolve
* issues like a stuck channel.
*
* BTW experimental-anchors feature provides a solution to this problem.
*
* [1] https://github.com/ElementsProject/lightning/issues/6362
* */
if (ld->config.ignore_fee_limits)
min = 1;
else {
@ -1156,10 +1168,12 @@ u32 feerate_min(struct lightningd *ld, bool *unknown)
/* FIXME: This is what bcli used to do: halve the slow feerate! */
min /= 2;
/* We can't allow less than feerate_floor, since that won't relay */
if (min < get_feerate_floor(topo))
return get_feerate_floor(topo);
}
if (min < get_feerate_floor(topo))
return get_feerate_floor(topo);
return min;
}