mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-19 01:43:36 +01:00
Code Issues Projects Releases Wiki Activity

psbt-fix: set to NULL, which will cleanup dangling pointer

Browse Source 
On July 18th, @jgriffiths wrote:

> You need to set this to NULL after freeing it, otherwise if line 72 returns you have a dangling pointer and potential later use-after-free here. Alternately use wally_psbt_set_input_final_witness(NULL) which will free any existing witness and set the value to NULL.

Reported-By: @jgriffiths
This commit is contained in:
niftynei 2023-12-05 02:03:20 -06:00 committed by Rusty Russell
parent b250bca429
commit 7717f6e4df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/psbt_internal.c
View File

@ -65,7 +65,7 @@ psbt_input_set_final_witness_stack(const tal_t *ctx,
size_t size, max = tal_count(data);
bool ok;
wally_tx_witness_stack_free(in->final_witness);
wally_psbt_input_set_final_witness(in, NULL);
/* FIXME: return an error?? */
if (!next_size(&data, &max, &size))