mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-18 05:12:45 +01:00
Code Issues Projects Releases Wiki Activity

common/gossip_rcvd_filter: avoid DoS.

Browse Source 
If they don't send us a gossip timestamp filter, we won't be sending
them any gossip, thus won't be aging the gossip_rcvd_filter.  So
restrict it to 10,000 elements just to be sure.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2019-09-06 15:39:39 +09:30 committed by Christian Decker
parent c99906a9a9
commit 7514a87b5e
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/gossip_rcvd_filter.c
View File

@ -73,9 +73,13 @@ void gossip_rcvd_filter_add(struct gossip_rcvd_filter *f, const u8 *msg)
u64 key; u64 key;
/* We don't attach destructor here directly to tag; would be neat, /* We don't attach destructor here directly to tag; would be neat,
* but it's also an extra allocation */ * but it's also an extra allocation. */
if (extract_msg_key(msg, &key)) if (extract_msg_key(msg, &key)) {
htable_add(f->cur, key, tal_dup(f->cur, u64, &key)); htable_add(f->cur, key, tal_dup(f->cur, u64, &key));
/* Don't let it fill up forever though. */
if (htable_count(f->cur) > 10000)
gossip_rcvd_filter_age(f);
}
} }
/* htable is fast, but it's also horribly manual. */ /* htable is fast, but it's also horribly manual. */