From 72327f5cc2c96dd06671bf85ff4282dbe80a3b6f Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 8 Apr 2020 09:15:50 +0930 Subject: [PATCH] libplugin: fix compilation issue on recent gccs. They now use -fno-common by default, so duplicated variables cause a link error: /usr/bin/ld: common/utils.o:(.bss+0x10): multiple definition of `chainparams'; plugins/libplugin.o:(.bss+0x0): first defined here collect2: error: ld returned 1 exit status make: *** [Makefile:408: plugins/autoclean] Error 1 This was introduced in 9ebfdf0b8c8faa0267cbc4c55474b968c2467c32. Fixes: #3597 Signed-off-by: Rusty Russell Changelog-Fixed: Multiple definition of chainparams on Fedora (or other really recent gcc) --- plugins/libplugin.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/plugins/libplugin.c b/plugins/libplugin.c index 02cb0dd12..20c2b8b9b 100644 --- a/plugins/libplugin.c +++ b/plugins/libplugin.c @@ -20,8 +20,6 @@ #define READ_CHUNKSIZE 4096 -const struct chainparams *chainparams; - bool deprecated_apis; struct plugin_timer {