From 70410b8ee8dc5c819ec65aa2d3aaace376ca0639 Mon Sep 17 00:00:00 2001
From: Christian Decker <decker.christian@gmail.com>
Date: Sat, 2 Jan 2021 14:29:39 +0100
Subject: [PATCH] pytest: Test LightningRpc and plugin command notification
 support

---
 tests/plugins/countdown.py | 19 +++++++++++++++++++
 tests/test_plugin.py       | 25 +++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100755 tests/plugins/countdown.py

diff --git a/tests/plugins/countdown.py b/tests/plugins/countdown.py
new file mode 100755
index 000000000..fce5a6f66
--- /dev/null
+++ b/tests/plugins/countdown.py
@@ -0,0 +1,19 @@
+#!/usr/bin/env python3
+
+from pyln.client import Plugin
+import time
+
+plugin = Plugin()
+
+
+@plugin.method("countdown")
+def countdown(count, plugin, request):
+    count = int(count)
+    for i in range(count):
+        time.sleep(0.1)
+        request.notify("{}/{}".format(i, count), "INFO")
+
+    return "Done"
+
+
+plugin.run()
diff --git a/tests/test_plugin.py b/tests/test_plugin.py
index ca4c505de..55bfe70b7 100644
--- a/tests/test_plugin.py
+++ b/tests/test_plugin.py
@@ -2202,3 +2202,28 @@ def test_dynamic_args(node_factory):
     l1.rpc.plugin_stop(plugin_path)
 
     assert [p for p in l1.rpc.listconfigs()['plugins'] if p['path'] == plugin_path] == []
+
+
+def test_pyln_request_notify(node_factory):
+    """Test that pyln-client plugins can send notifications.
+    """
+    plugin_path = os.path.join(
+        os.path.dirname(__file__), 'plugins/countdown.py'
+    )
+    l1 = node_factory.get_node(options={'plugin': plugin_path})
+    notifications = []
+
+    def n(*args, message, **kwargs):
+        print("Got a notification:", message)
+        notifications.append(message)
+
+    with l1.rpc.notify(n):
+        l1.rpc.countdown(10)
+
+    expected = ['{}/10'.format(i) for i in range(10)]
+    assert expected == notifications
+
+    # Calling without the context manager we should not get any notifications
+    notifications = []
+    l1.rpc.countdown(10)
+    assert notifications == []