mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 11:59:16 +01:00
Code Issues Projects Releases Wiki Activity

reckless: fix crash on non-verbose output

Browse source 
Also cleans up verbose logic
This commit is contained in:
Alex Myers 2023-04-14 13:16:50 -05:00 • committed by ShahanaFarooqui
parent f5a132314a
commit 6ac0842aa1
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tools/reckless
View file

@ -357,17 +357,11 @@ def _install_plugin(src: InstInfo) -> bool:
url = f"{GITHUB_COM}" + src.repo.split("github.com")[-1]
else:
url = src.repo
# Ugly, but interactively handling stderr gets hairy.
if logging.root.level < logging.WARNING:
git = Popen(['git', 'clone', url, str(clone_path)],
stdout=PIPE, stderr=PIPE)
else:
git = Popen(['git', 'clone', url, str(clone_path)],
stdout=PIPE, stderr=PIPE)
git = Popen(['git', 'clone', url, str(clone_path)],
stdout=PIPE, stderr=PIPE)
git.wait()
if git.returncode != 0:
if git.stderr:
print(git.stderr.read().decode())
logging.debug(git.stderr.read().decode())
if Path(clone_path).exists():
remove_dir(clone_path)
print('Error: Failed to clone repo')
@ -406,7 +400,8 @@ def _install_plugin(src: InstInfo) -> bool:
print('dependencies installed successfully')
else:
print('error encountered installing dependencies')
logging.debug(pip.stdout.read())
if pip.stdout:
logging.debug(pip.stdout.read())
return False
test = Popen([Path(plugin_path).joinpath(src.entry)], cwd=str(plugin_path),
stdout=PIPE, stderr=PIPE, text=True)